Added missing __nullable attributes to failure blocks in `AFHTTPRequestOperationManager` and `AFHTTPSessionManager` by chuganzy · Pull Request #3057 · AFNetworking/AFNetworking · GitHub
Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Added missing __nullable attributes to failure blocks in AFHTTPRequestOperationManager and AFHTTPSessionManager#3057

Closed
chuganzy wants to merge 2 commits into
AFNetworking:masterfrom
chuganzy:nullable
Closed

Added missing __nullable attributes to failure blocks in AFHTTPRequestOperationManager and AFHTTPSessionManager#3057
chuganzy wants to merge 2 commits into
AFNetworking:masterfrom
chuganzy:nullable

Conversation

@chuganzy

Copy link
Copy Markdown
Contributor

as titled

@kcharwood

Copy link
Copy Markdown
Contributor

@chuganzy

chuganzy commented Oct 15, 2015

Copy link
Copy Markdown
Contributor Author

@kcharwood

Copy link
Copy Markdown
Contributor

Ah you're right! I totally missed that looking over that code. I'll get this patch in!

Thanks 🍻

@kcharwood kcharwood modified the milestones: 2.6.1, 2.6.2 Oct 15, 2015
kcharwood added a commit that referenced this pull request Oct 21, 2015
@kcharwood

Copy link
Copy Markdown
Contributor

Added unit test and merged in 2.x with c90c3da

kcharwood added a commit that referenced this pull request Oct 21, 2015
@kcharwood

Copy link
Copy Markdown
Contributor

Merged in 3.0.0 with 9200627

@kcharwood

Copy link
Copy Markdown
Contributor

🍻

@kcharwood kcharwood closed this Oct 21, 2015
@chuganzy

Copy link
Copy Markdown
Contributor Author

@kcharwood kcharwood changed the title add missing __nullable attributes Added missing __nullable attributes to failure blocks in AFHTTPRequestOperationManager and AFHTTPSessionManager Nov 3, 2015
@kcharwood kcharwood added the fixed label Nov 3, 2015
sergiou87 pushed a commit to plexinc/afnetworking that referenced this pull request Dec 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants