{{ message }}
Repository navigation
fix(project-preparser): preserve note block content - #1080
Merged
Merged
Conversation
Read notes as text until noteEnd so language block markers can appear in their content. Preserve raw source lines and existing validation for other document blocks. Add root and nested note regressions and document the behavior. Fixes 8f4e#1062
andorthehood
added
contributor
compiler
andorthehood
approved these changes
Oct 17, 2026
irimias57
approved these changes
Oct 17, 2026
irimias57
left a comment
irimias57
left a comment
Member
There was a problem hiding this comment.
Thank you for the contribution, Nigel! The compiler-side change is well scoped, the new coverage is thorough, and the implementation correctly preserves note contents until the matching noteEnd. Nicely done!
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes can now contain lines such as
module declarations hold stateandmoduleEndwithout being parsed as source structure. The parser keeps the note text untilnoteEndand preserves its whitespace and source identity.Added 20 parser regressions for root notes and nested groups. Missing terminators still report unclosed notes. Existing source block validation and parser snapshots pass.
Fixes #1062
All 414 tests pass across three compiler packages. Biome and the affected type checks also pass.
The commit hook ran the affected type checks for both changed TypeScript files.
Prepared with Codex assistance. I reviewed the change and the test results.