{{ message }}
Repository navigation
fix: retry final graph metadata before declaring the workspace ready - #919
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completed graph task clears polling and marks the project Ready before fetching its final metadata. If that GET fails transiently, the view stays Ready with no graph ID; clicking Enter Environment Setup cannot proceed. Keep the existing task poll running until a successful project response contains the graph ID, then stop polling and show Ready.
Validation: 6 actual-handler tests pass (baseline: 4 failures, 2 controls pass), including transient errors, missing graph IDs, pending metadata, successful recovery, and existing task-failure behavior. In Chrome, the actual MainView/Step1/GraphPanel and VueRouter recover after one locally simulated GET failure and allow the next step; the baseline leaves a nonfunctional Ready page. All API calls use an isolated in-memory adapter. Full Vite production build and git diff --check pass; no new timer or retry loop is introduced.
Reviewed actual #870/#494 patches, #125, and exact #857 MainView head source; none fixes this completion order. AI assistance was used for implementation and tests.