fix: remove completed IPC responses after server cleanup by rudycelekli · Pull Request #908 · 666ghj/MiroFish · GitHub
Skip to content

fix: remove completed IPC responses after server cleanup - #908

Open
rudycelekli wants to merge 1 commit into
666ghj:mainfrom
rudycelekli:fix/clean-completed-ipc-response-files-20261021
Open

rudycelekli wants to merge 1 commit into
666ghj:mainfrom
rudycelekli:fix/clean-completed-ipc-response-files-20261021

Conversation

@rudycelekli

Copy link
Copy Markdown

The IPC server normally deletes a command after writing its response. On successful receipt, the client tried deleting that command again and then deleting the response inside one try block. The expected missing-command exception skipped response cleanup, retaining the complete response file after an otherwise successful exchange.

Attempt command and response cleanup independently. Either file may already be absent without preventing cleanup of the other or changing the delivered payload.

Validation:

  • Actual client/server round trip deterministically observes the server-deleted command: baseline leaves the response behind; fixed code removes it.
  • A second control covers receipt while the command still exists. Both protocol directories end empty and the successful payload is retained.
  • Baseline: 1 failure, 1 passing control. Fixed full backend suite: 131 passed.
  • git diff --check passes.

AI assistance was used to investigate and prepare this patch. Tests use local threads, production IPC classes, and temporary files. No simulation or model calls are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant