Update of hawk and qs to latest version by Olivier-Moreau · Pull Request #2751 · request/request · GitHub
Skip to content

Update of hawk and qs to latest version - #2751

Merged
mikeal merged 1 commit into
request:masterfrom
Olivier-Moreau:update-packets
Aug 24, 2017
Merged

mikeal merged 1 commit into
request:masterfrom
Olivier-Moreau:update-packets

Conversation

@Olivier-Moreau

@Olivier-Moreau Olivier-Moreau commented Aug 24, 2017 •

Copy link
Copy Markdown
Contributor

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

I updated hawk from 3.1.3 to 6.0.2 (still a ~ for version managing)
I updated qs too from 6.4.0 to 6.5.0 (kept the ~)

npm test ran without error. I didn't add a test since I only changed version.

@mikeal
mikeal merged commit 479143d into request:master Aug 24, 2017
@Olivier-Moreau
Olivier-Moreau deleted the update-packets branch August 25, 2017 07:14
gtmanfred added a commit to gtmanfred/salt that referenced this pull request Aug 25, 2017
This fails on centos 6 because its node is too old to support the version of
hawk bumped here request/request#2751, we can still
test the functionality.  This will pull from github, and install a specific tag
version, and we still do the uninstall using the github path.

This should be more stable.
@louisbuchbinder

louisbuchbinder commented Sep 19, 2017 •

Copy link
Copy Markdown

@lostip

lostip commented Sep 20, 2017 •

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants