{{ message }}
FIX: set_font() should not do full font reset for str arguments#31956
Open
timhoffm wants to merge 2 commits into
Open
FIX: set_font() should not do full font reset for str arguments#31956timhoffm wants to merge 2 commits into
timhoffm wants to merge 2 commits into
Conversation
timhoffm
force-pushed
the
fix-font-priority
branch
from
b920117 to
4d3f000
Compare
rcomer
reviewed
Jun 27, 2026
timhoffm
commented
Jun 27, 2026
Member
Closes matplotlib#27608 A str is interpreted as a fontconfig pattern and should only update the specified parts. This is solution 2 from matplotlib#27608 (comment) This is a breaking change, but there is no smooth transition path. I'd label this a bug fix and by that justify the immediate change. Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
timhoffm
force-pushed
the
fix-font-priority
branch
from
e30bc75 to
b494ace
Compare
rcomer
reviewed
Jul 3, 2026
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
Member
Author
rcomer
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27608
PR summary
A str is interpreted as a fontconfig pattern and should only update the specified parts.
This is solution 2 from #27608 (comment)
This is a breaking change, but there is no smooth transition path. I'd label this a bug fix and by that justify the immediate change.
AI Disclosure
Solution strategy previously discussed in the above mentioned issue. Implementation and tests supported with AI, but human-edited for some fine-tuning and human-verified.