{{ message }}
Repository navigation
Fix assumption that all CodeQL bundle URLs contain the tag name of the bundle - #1517
Merged
henrymercer merged 5 commits intoFeb 6, 2023
Merged
Conversation
aeisenberg
reviewed
Feb 3, 2023
Contributor
Contributor
|
OK, So I tried again, but this time with a publicly available CLI version that has a non-standard tag. The download worked, but it looks like the tool wasn't cached in the toolcache. I don't think that's a problem. |
aeisenberg
approved these changes
Feb 6, 2023
aeisenberg
left a comment
aeisenberg
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I've convinced myself that this fix will correctly download codeqls from arbitrary github releases.
Contributor
Author
henrymercer
deleted the
henrymercer/fix/not-all-bundle-urls-contain-tag
branch
February 6, 2023 18:20
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing controlled switchover, we inadvertently introduced an assumption that all CodeQL bundle URLs contain the tag name of the bundle, for example
codeql-bundle-2020230120. This is in fact not the case on GHES, where the bundle URL may be https://example.githubenterprise.com/api/v3/repos/github/codeql-action/releases/assets/1 when the CodeQL sync tool has been used to sync the CodeQL bundle to the GHES instance.This PR adds a regression test and fixes that assumption.
Merge / deployment checklist