Update `@octokit/plugin-rest-endpoint-methods` to version 6.x by desrosj · Pull Request #283 · actions/github-script · GitHub
Skip to content

Update @octokit/plugin-rest-endpoint-methods to version 6.x#283

Merged
joshmgross merged 4 commits into
actions:mainfrom
desrosj:update/plugin-rest-endpoint-methods
Aug 26, 2022
Merged

Update @octokit/plugin-rest-endpoint-methods to version 6.x#283
joshmgross merged 4 commits into
actions:mainfrom
desrosj:update/plugin-rest-endpoint-methods

Conversation

@desrosj

@desrosj desrosj commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

This updates the dependency to the latest version within current SemVer constraints.

v5.14.0 specifically includes a number of new endpoints, including .rest.actions.reRunWorkflowFailedJobs(), which is the one I am trying to use when discovering this issue. Currently the following error is given:

Error: Unhandled error: TypeError: github.rest.actions.reRunWorkflowFailedJobs is not a function

@desrosj
Update @octokit/plugin-rest-endpoint-methods.
6e70142 
This updates the dependency to the latest version within current SemVer constraints.
@desrosj desrosj requested a review from a team August 18, 2022 17:52
@desrosj

desrosj commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

@desrosj desrosj mentioned this pull request Aug 18, 2022
Closed
@joshmgross

joshmgross commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Happy to update this PR if these versions are no longer supported.

The latest version of this action is using Node 16, so I'm good with updating to the latest version

https://github.com/actions/github-script/blob/main/action.yml#L29-L30

@desrosj desrosj changed the title Update @octokit/plugin-rest-endpoint-methods. Update @octokit/plugin-rest-endpoint-methods to version 6.x Aug 25, 2022
@desrosj

desrosj commented Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

I've updated the version to the latest (v6.3.0).

I also noticed that the version numbers in the package.json and package-lock.json files were not updated for versions 6.1 and 6.1.1. I bumped these to values to 6.2.0 to make it easier to tag the next release after this PR is merged.

joshmgross
joshmgross approved these changes Aug 26, 2022
View reviewed changes

@joshmgross joshmgross left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I can push changes to update the licenses.

Since the only breaking changes are dropping support for Node 10 and 12 which won't affect this action, I don't think we need a major version bump to v7 for actions/github-script

@joshmgross joshmgross merged commit c713e51 into actions:main Aug 26, 2022
@joshmgross

joshmgross commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

@desrosj desrosj deleted the update/plugin-rest-endpoint-methods branch August 26, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@joshmgross joshmgross joshmgross approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@desrosj @joshmgross