Issue 47015: Update tests from asyncore to asyncio - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: arhadthedev, asvetlov, giampaolo.rodola, josiahcarlson, stutzbach, yselivanov
Priority: normal Keywords: patch

Created on 2022-03-14 20:38 by arhadthedev, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31876 merged arhadthedev, 2022-03-14 20:40
Messages (3)
msg415185 - (view) Author: Oleg Iarygin (arhadthedev) * Date: 2022-03-14 20:38 
PEP 594 – Removing dead batteries from the standard library [1] removes asyncore and asynchat in 3.12 with the following note:

> The asyncore module is also used in stdlib tests. The tests for ftplib, logging, smptd, smtplib, and ssl are partly based on asyncore. These tests must be updated to use asyncio or threading.

(Note: the tests for `os` module are not mentioned and smtpd will be removed in 3.12 along with its tests anyway)

I'm performing the update now to avoid keeping asynchat and asyncore as private subpackages of `test` package.

[1] https://peps.python.org/pep-0594/
msg415518 - (view) Author: Oleg Iarygin (arhadthedev) * Date: 2022-03-18 18:46 
The PR is ready for a review; I sorted out all bugs.
msg415608 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2022-03-20 14:39 
New changeset 3ae975f1ac880c47d51cca6c9e305547bd365be7 by Oleg Iarygin in branch 'main':
bpo-47015: Update test_os from asyncore to asyncio (GH-31876)
https://github.com/python/cpython/commit/3ae975f1ac880c47d51cca6c9e305547bd365be7