Issue 40401: pythoncore.vcxproj fails to load due to duplicated "..\Include\pyhash.h" - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ammar2, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2020-04-26 23:53 by ammar2, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19725 merged ammar2, 2020-04-26 23:56
Messages (3)
msg367334 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-04-26 23:53 
The pythoncore project currently fails to load in Visual Studio with:

    cpython\PCbuild\pythoncore.vcxproj : error  : Cannot load project with duplicated project items: ..\Include\pyhash.h is included as 'ClInclude' and as 'ClInclude' item types. 


Looks like https://github.com/python/cpython/commit/c5fc15685202cda73f7c3f5c6f299b0945f58508#diff-fc48a1700be0140b57a172ea101297de accidentally introduced a duplicate for "..\Include\pyhash.h"
msg367352 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2020-04-27 02:08 
New changeset a494caa14bfa412af77792007c34274902fabb7b by Ammar Askar in branch 'master':
bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (GH-19725)
https://github.com/python/cpython/commit/a494caa14bfa412af77792007c34274902fabb7b
msg367353 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2020-04-27 02:09 
Thanks for the patch :)