Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 62
Expand file tree
/
Copy pathcoding_guide.html
More file actions
351 lines (330 loc) · 21.4 KB
/
Copy pathcoding_guide.html
File metadata and controls
351 lines (330 loc) · 21.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Reviewers guideline — Matplotlib 3.2.2 documentation</title>
<link rel="stylesheet" href="../_static/mpl.css?v3.2.2-2-g137edd56a" type="text/css" />
<link rel="stylesheet" href="../_static/pygments.css" type="text/css" />
<link rel="stylesheet" type="text/css" href="../_static/graphviz.css" />
<link rel="stylesheet" type="text/css" href="../_static/copybutton.css" />
<link rel="stylesheet" type="text/css" href="../_static/gallery.css" />
<link rel="stylesheet" type="text/css" href="../_static/gallery-binder.css" />
<link rel="stylesheet" type="text/css" href="../_static/gallery-dataframe.css" />
<script id="documentation_options" data-url_root="../" src="../_static/documentation_options.js"></script>
<script src="../_static/jquery.js"></script>
<script src="../_static/underscore.js"></script>
<script src="../_static/doctools.js"></script>
<script src="../_static/language_data.js"></script>
<script src="../_static/clipboard.min.js"></script>
<script src="../_static/copybutton.js"></script>
<script async="async" src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.7/latest.js?config=TeX-AMS-MML_HTMLorMML"></script>
<link rel="search" type="application/opensearchdescription+xml"
title="Search within Matplotlib 3.2.2 documentation"
href="../_static/opensearch.xml"/>
<link rel="shortcut icon" href="../_static/favicon.ico"/>
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
<link rel="next" title="Release Guide" href="release_guide.html" />
<link rel="prev" title="Two and three dots in difference specs" href="gitwash/dot2_dot3.html" />
<link rel="top" title="Matplotlib 3.2.2 documentation" href="#" />
<link rel="canonical" href="https://matplotlib.org/stable/devel/coding_guide.html" />
<link rel="stylesheet" href="../_static/custom.css" type="text/css" />
<meta name="viewport" content="width=device-width, initial-scale=0.9, maximum-scale=0.9" />
<script data-domain="matplotlib.org" defer="defer" src="https://views.scientific-python.org/js/script.js"></script>
</head><body>
<div id="unreleased-message"> You are reading an old version of the documentation (v3.2.2). For the latest version see <a href="https://matplotlib.org/stable/devel/coding_guide.html">https://matplotlib.org/stable/devel/coding_guide.html</a></div>
<!--
<div id="annc-banner">
</div>
-->
<div style="background-color: white; text-align: left; padding: 10px 10px 15px 15px; position: relative;">
<a href="../index.html">
<div style="float: left; position: absolute; width: 496px; bottom: 0; padding-bottom: 24px"><span style="float: right; color: #789; background: white">Version 3.2.2</span></div>
<img src="../_static/logo2_compressed.svg" height="125px" border="0" alt="matplotlib"/></a>
<!-- The "Fork me on github" ribbon -->
<div id="forkongithub"><a href="https://github.com/matplotlib/matplotlib">Fork me on GitHub</a></div>
</div>
<nav class="main-nav">
<ul>
<li><a href="../users/installing.html">Installation</a></li>
<li><a href="../contents.html">Documentation</a></li>
<li><a href="../gallery/index.html">Examples</a></li>
<li><a href="../tutorials/index.html">Tutorials</a></li>
<li><a href="index.html">Contributing</a></li>
<li class="nav-right">
<form class="search" action="../search.html" method="get">
<input type="text" name="q" aria-labelledby="searchlabel" placeholder="Search"/>
</form>
</li>
</ul>
</nav>
<div class="related" role="navigation" aria-label="related navigation">
<h3>Navigation</h3>
<ul>
<li class="right" style="margin-right: 10px">
<a href="../genindex.html" title="General Index"
accesskey="I">index</a></li>
<li class="right" >
<a href="../py-modindex.html" title="Python Module Index"
>modules</a> |</li>
<li class="right" >
<a href="release_guide.html" title="Release Guide"
accesskey="N">next</a> |</li>
<li class="right" >
<a href="gitwash/dot2_dot3.html" title="Two and three dots in difference specs"
accesskey="P">previous</a> |</li>
<li><a href="../index.html">home</a>| </li>
<li><a href="../contents.html">contents</a> »</li>
<li class="nav-item nav-item-1"><a href="index.html" accesskey="U">The Matplotlib Developers' Guide</a> »</li>
<li class="nav-item nav-item-this"><a href="">Reviewers guideline</a></li>
</ul>
</div>
<div class="sphinxsidebar" role="navigation" aria-label="main navigation">
<div class="sphinxsidebarwrapper">
<h3><a href="../contents.html">Table of Contents</a></h3>
<ul>
<li><a class="reference internal" href="#">Reviewers guideline</a><ul>
<li><a class="reference internal" href="#pull-request-checklist">Pull request checklist</a><ul>
<li><a class="reference internal" href="#branch-selection">Branch selection</a></li>
<li><a class="reference internal" href="#documentation">Documentation</a></li>
</ul>
</li>
<li><a class="reference internal" href="#pr-review-guidelines">PR Review guidelines</a></li>
<li><a class="reference internal" href="#branches-and-backports">Branches and Backports</a><ul>
<li><a class="reference internal" href="#automated-backports">Automated backports</a></li>
<li><a class="reference internal" href="#manual-backports">Manual backports</a></li>
</ul>
</li>
</ul>
</li>
</ul>
<div class="relations">
<h3>Related Topics</h3>
<ul>
<li><a href="../contents.html">Documentation overview</a><ul>
<li><a href="index.html">The Matplotlib Developers' Guide</a><ul>
<li>Previous: <a href="gitwash/dot2_dot3.html" title="previous chapter">Two and three dots in difference specs</a></li>
<li>Next: <a href="release_guide.html" title="next chapter">Release Guide</a></li>
</ul></li>
</ul></li>
</ul>
</div>
<div id="sidebar-pagesource" role="note" aria-label="source link"
style="margin-top: 1.5em; padding-top: 0.1em; border-top: 1px solid #86989b">
<a href="../_sources/devel/coding_guide.rst.txt"
style="color: #c0c0c0" rel="nofollow">Show Page Source</a>
</div>
</div>
</div>
<div class="document">
<div class="documentwrapper">
<div class="bodywrapper">
<div class="body" role="main">
<div class="section" id="reviewers-guideline">
<span id="reviewers-guide"></span><h1>Reviewers guideline<a class="headerlink" href="#reviewers-guideline" title="Permalink to this headline">¶</a></h1>
<div class="section" id="pull-request-checklist">
<span id="id1"></span><h2>Pull request checklist<a class="headerlink" href="#pull-request-checklist" title="Permalink to this headline">¶</a></h2>
<div class="section" id="branch-selection">
<h3>Branch selection<a class="headerlink" href="#branch-selection" title="Permalink to this headline">¶</a></h3>
<p>Generally, all pull requests (<em>PRs</em>) should target the master branch. Other
branches are fed through automatic or manual backports. Directly targeting
other branches is only rarely necessary for special maintenance work.</p>
</div>
<div class="section" id="documentation">
<h3>Documentation<a class="headerlink" href="#documentation" title="Permalink to this headline">¶</a></h3>
<ul class="simple">
<li>Every new feature should be documented. If it's a new module, don't
forget to add a new rst file to the API docs.</li>
<li>Each high-level plotting function should have a small example in
the <code class="docutils literal notranslate"><span class="pre">Examples</span></code> section of the docstring. This should be as simple as
possible to demonstrate the method. More complex examples should go into
a dedicated example file in the <code class="file docutils literal notranslate"><span class="pre">examples</span></code> directory, which will be
rendered to the examples gallery in the documentation.</li>
<li>Build the docs and make sure all formatting warnings are addressed.</li>
<li>See <a class="reference internal" href="documenting_mpl.html#documenting-matplotlib"><span class="std std-ref">Writing documentation</span></a> for our documentation style guide.</li>
<li>If your change is a major new feature, add an entry to
<code class="file docutils literal notranslate"><span class="pre">doc/users/whats_new.rst</span></code>.</li>
<li>If you change the API in a backward-incompatible way, please
document it in <code class="file docutils literal notranslate"><span class="pre">doc/api/api_changes.rst</span></code>.</li>
</ul>
</div>
</div>
<div class="section" id="pr-review-guidelines">
<h2>PR Review guidelines<a class="headerlink" href="#pr-review-guidelines" title="Permalink to this headline">¶</a></h2>
<ul>
<li><p class="first">Be patient and <a class="reference external" href="https://youtu.be/tzFWz5fiVKU?t=49m30s">kind</a> with
contributors.</p>
</li>
<li><p class="first">If you have commit rights, then you are trusted to use them. Please
help review and merge PRs!</p>
</li>
<li><p class="first">If you have the rights to set labels, tag the PR with descriptive labels.
See the <a class="reference external" href="https://github.com/matplotlib/matplotlib/labels">list of labels</a>.</p>
</li>
<li><p class="first">Set the milestone according to these rules:</p>
<ul class="simple">
<li><em>New features and API changes</em> are milestoned for the next point-release
<code class="docutils literal notranslate"><span class="pre">v3.X.0</span></code>.</li>
<li><em>Bugfixes and docstring changes</em> are milestoned for the next bugfix
release <code class="docutils literal notranslate"><span class="pre">v3.X.Y</span></code></li>
<li><em>Documentation changes</em> (all .rst files and examples) are milestoned
<code class="docutils literal notranslate"><span class="pre">v3.X-doc</span></code></li>
</ul>
<p>If multiple rules apply, choose the first matching from the above list.</p>
<p>All of these PRs should target the master branch. The milestone tag triggers
an <a class="reference internal" href="#automated-backports"><span class="std std-ref">automatic backport</span></a> for milestones which have
a corresponding branch.</p>
</li>
<li><p class="first">Documentation and examples may be merged by the first reviewer. Use
the threshold "is this better than it was?" as the review criteria.</p>
</li>
<li><p class="first">For code changes (anything in <code class="docutils literal notranslate"><span class="pre">src</span></code> or <code class="docutils literal notranslate"><span class="pre">lib</span></code>) at least two
core developers (those with commit rights) should review all pull
requests. If you are the first to review a PR and approve of the
changes use the GitHub <a class="reference external" href="https://help.github.com/articles/reviewing-changes-in-pull-requests/">'approve review'</a>
tool to mark it as such. If you are a subsequent reviewer please
approve the review and if you think no more review is needed, merge
the PR.</p>
<p>Ensure that all API changes are documented in
<code class="file docutils literal notranslate"><span class="pre">doc/api/api_changes</span></code> and significant new features have and
entry in <code class="file docutils literal notranslate"><span class="pre">doc/user/whats_new</span></code>.</p>
<ul>
<li><p class="first">If a PR already has a positive review, a core developer (e.g. the first
reviewer, but not necessarily) may champion that PR for merging. In order
to do so, they should ping all core devs both on GitHub and on the dev
mailing list, and label the PR with the "Merge with single review?" label.
Other core devs can then either review the PR and merge or reject it, or
simply request that it gets a second review before being merged. If no one
asks for such a second review within a week, the PR can then be merged on
the basis of that single review.</p>
<p>A core dev should only champion one PR at a time and we should try to keep
the flow of championed PRs reasonable.</p>
</li>
</ul>
</li>
<li><p class="first">Make sure the Travis, Appveyor, CircleCI, and codecov tests are passing
before merging.</p>
<ul class="simple">
<li>Whenever a pull request is created or updated, Travis and Appveyor
automatically runs the test suite on all versions of Python
supported by Matplotlib. The <code class="xref py py-obj docutils literal notranslate"><span class="pre">tox</span></code> support in Matplotlib may be
useful for testing locally.</li>
</ul>
</li>
<li><p class="first">Do not self merge, except for 'small' patches to un-break the CI or
when another reviewer explicitly allows it (ex, "Approve modulo CI
passing, may self merge when green").</p>
</li>
<li><p class="first">Squashing is case-by-case. The balance is between burden on the
contributor, keeping a relatively clean history, and keeping a
history usable for bisecting. The only time we are really strict
about it is to eliminate binary files (ex multiple test image
re-generations) and to remove upstream merges.</p>
</li>
<li><p class="first">Do not let perfect be the enemy of the good, particularly for
documentation or example PRs. If you find yourself making many
small suggestions, either open a PR against the original branch,
push changes to the contributor branch, or merge the PR and then
open a new PR against upstream.</p>
</li>
<li><p class="first">If you push to a contributor branch leave a comment explaining what
you did, ex "I took the liberty of pushing a small clean-up PR to
your branch, thanks for your work.". If you are going to make
substantial changes to the code or intent of the PR please check
with the contributor first.</p>
</li>
</ul>
</div>
<div class="section" id="branches-and-backports">
<h2>Branches and Backports<a class="headerlink" href="#branches-and-backports" title="Permalink to this headline">¶</a></h2>
<p>The current active branches are</p>
<dl class="docutils">
<dt><em>master</em></dt><dd>This will be Matplotlib 3.0. Supports Python 3.5+.</dd>
<dt><em>v2.2.x</em></dt><dd>Maintenance branch for Matplotlib 2.2 LTS. Supports Python 2.7, 3.4+</dd>
<dt><em>v2.2.N-doc</em></dt><dd>Documentation for the current release. On a patch release, this will be replaced
by a properly named branch for the new release.</dd>
</dl>
<p>We always will backport to 2.2.x</p>
<ul class="simple">
<li>critical bug fixes (segfault, failure to import, things that the
user can not work around)</li>
<li>fixes for regressions against 2.0 or 2.1</li>
</ul>
<p>Everything else (regressions against 1.x versions, bugs/api
inconsistencies the user can work around in their code) are on a
case-by-case basis, should be low-risk, and need someone to advocate
for and shepherd through the backport.</p>
<p>The only changes to be backported to 2.2.N-doc are changes to
<code class="docutils literal notranslate"><span class="pre">doc</span></code>, <code class="docutils literal notranslate"><span class="pre">examples</span></code>, or <code class="docutils literal notranslate"><span class="pre">tutorials</span></code>. Any changes to
<code class="docutils literal notranslate"><span class="pre">lib</span></code> or <code class="docutils literal notranslate"><span class="pre">src</span></code> should not be backported to this branch.</p>
<div class="section" id="automated-backports">
<span id="id2"></span><h3>Automated backports<a class="headerlink" href="#automated-backports" title="Permalink to this headline">¶</a></h3>
<p>We use meeseeksdev bot to automatically backport merges to the correct
maintenance branch base on the milestone. To work properly the
milestone must be set before merging. If you have commit rights, the
bot can also be manually triggered after a merge by leaving a message
<code class="docutils literal notranslate"><span class="pre">@meeseeksdev</span> <span class="pre">backport</span> <span class="pre">to</span> <span class="pre">BRANCH</span></code> on the PR. If there are conflicts
meeseekdevs will inform you that the backport needs to be done
manually.</p>
<p>The target branch is configured by putting <code class="docutils literal notranslate"><span class="pre">on-merge:</span> <span class="pre">backport</span> <span class="pre">to</span>
<span class="pre">TARGETBRANCH</span></code> in the milestone description on it's own line.</p>
<p>If the bot is not working as expected, please report issues to
<a class="reference external" href="https://github.com/MeeseeksBox/MeeseeksDev">Meeseeksdev</a>.</p>
</div>
<div class="section" id="manual-backports">
<h3>Manual backports<a class="headerlink" href="#manual-backports" title="Permalink to this headline">¶</a></h3>
<p>When doing backports please copy the form used by meeseekdev,
<code class="docutils literal notranslate"><span class="pre">Backport</span> <span class="pre">PR</span> <span class="pre">#XXXX:</span> <span class="pre">TITLE</span> <span class="pre">OF</span> <span class="pre">PR</span></code>. If you need to manually resolve
conflicts make note of them and how you resolved them in the commit
message.</p>
<p>We do a backport from master to v2.2.x assuming:</p>
<ul class="simple">
<li><code class="docutils literal notranslate"><span class="pre">matplotlib</span></code> is a read-only remote branch of the matplotlib/matplotlib repo</li>
</ul>
<p>The <code class="docutils literal notranslate"><span class="pre">TARGET_SHA</span></code> is the hash of the merge commit you would like to
backport. This can be read off of the GitHub PR page (in the UI with
the merge notification) or through the git CLI tools.</p>
<p>Assuming that you already have a local branch <code class="docutils literal notranslate"><span class="pre">v2.2.x</span></code> (if not, then
<code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">checkout</span> <span class="pre">-b</span> <span class="pre">v2.2.x</span></code>), and that your remote pointing to
<code class="docutils literal notranslate"><span class="pre">https://github.com/matplotlib/matplotlib</span></code> is called <code class="docutils literal notranslate"><span class="pre">upstream</span></code>:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">git</span> <span class="n">fetch</span> <span class="n">upstream</span>
<span class="n">git</span> <span class="n">checkout</span> <span class="n">v2</span><span class="o">.</span><span class="mf">2.</span><span class="n">x</span> <span class="c1"># or include -b if you don't already have this.</span>
<span class="n">git</span> <span class="n">reset</span> <span class="o">--</span><span class="n">hard</span> <span class="n">upstream</span><span class="o">/</span><span class="n">v2</span><span class="o">.</span><span class="mf">2.</span><span class="n">x</span>
<span class="n">git</span> <span class="n">cherry</span><span class="o">-</span><span class="n">pick</span> <span class="o">-</span><span class="n">m</span> <span class="mi">1</span> <span class="n">TARGET_SHA</span>
<span class="c1"># resolve conflicts and commit if required</span>
</pre></div>
</div>
<p>Files with conflicts can be listed by <code class="xref py py-obj docutils literal notranslate"><span class="pre">git</span> <span class="pre">status</span></code>,
and will have to be fixed by hand (search on <code class="docutils literal notranslate"><span class="pre">>>>>></span></code>). Once
the conflict is resolved, you will have to re-add the file(s) to the branch
and then continue the cherry pick:</p>
<div class="highlight-default notranslate"><div class="highlight"><pre><span></span><span class="n">git</span> <span class="n">add</span> <span class="n">lib</span><span class="o">/</span><span class="n">matplotlib</span><span class="o">/</span><span class="n">conflicted_file</span><span class="o">.</span><span class="n">py</span>
<span class="n">git</span> <span class="n">add</span> <span class="n">lib</span><span class="o">/</span><span class="n">matplotlib</span><span class="o">/</span><span class="n">conflicted_file2</span><span class="o">.</span><span class="n">py</span>
<span class="n">git</span> <span class="n">cherry</span><span class="o">-</span><span class="n">pick</span> <span class="o">--</span><span class="k">continue</span>
</pre></div>
</div>
<p>Use your discretion to push directly to upstream or to open a PR; be
sure to push or PR against the <code class="xref py py-obj docutils literal notranslate"><span class="pre">v2.2.x</span></code> upstream branch, not <code class="xref py py-obj docutils literal notranslate"><span class="pre">master</span></code>!</p>
</div>
</div>
</div>
</div>
</div>
</div>
<div class="clearer"></div>
</div>
<footer>
<div class="footer">
© Copyright 2002 - 2012 John Hunter, Darren Dale, Eric Firing, Michael Droettboom and the Matplotlib development team; 2012 - 2018 The Matplotlib development team.
<br />
Last updated on Jun 17, 2020.
Created using
<a href="http://sphinx-doc.org/">Sphinx</a> 3.1.1.
Doc version v3.2.2-2-g137edd56a.
</div>
</footer>
</body>
</html>
You can’t perform that action at this time.