fixed missing ITypeOffset members np_inplace_*

lostmsu · lostmsu · commit d623d2ff4949 · 2020-11-30T10:36:36.000-08:00
diff --git a/src/runtime/native/ITypeOffsets.cs b/src/runtime/native/ITypeOffsets.cs
@@ -15,6 +15,8 @@ interface ITypeOffsets
         int mp_subscript { get; }
         int name { get; }
         int nb_add { get; }
+        int nb_inplace_add { get; }
+        int nb_inplace_subtract { get; }
         int ob_size { get; }
         int ob_type { get; }
         int qualname { get; }
diff --git a/src/runtime/native/TypeOffset.cs b/src/runtime/native/TypeOffset.cs
@@ -22,6 +22,8 @@ static partial class TypeOffset
         internal static int mp_subscript { get; private set; }
         internal static int name { get; private set; }
         internal static int nb_add { get; private set; }
+        internal static int nb_inplace_add { get; private set; }
+        internal static int nb_inplace_subtract { get; private set; }
         internal static int ob_size { get; private set; }
         internal static int ob_type { get; private set; }
         internal static int qualname { get; private set; }
@@ -73,6 +75,7 @@ internal static void Use(ITypeOffsets offsets)
             }
 
             ValidateUnusedTypeOffsetProperties(offsetProperties);
+            ValidateRequiredOffsetsPresent(offsetProperties);
         }
 
         static readonly BindingFlags FieldFlags = BindingFlags.NonPublic | BindingFlags.Static;
@@ -102,5 +105,48 @@ static void ValidateUnusedTypeOffsetProperties(PropertyInfo[] offsetProperties)
             extras.Sort();
             Debug.Assert(extras.Count == 0, message: string.Join(", ", extras));
         }
+
+        [Conditional("DEBUG")]
+        static void ValidateRequiredOffsetsPresent(PropertyInfo[] offsetProperties)
+        {
+            var present = new HashSet<string>(offsetProperties.Select(p => p.Name));
+            var missing = new HashSet<string>();
+
+            var thisAssembly = Assembly.GetExecutingAssembly();
+            var managedTypes = thisAssembly.GetTypes()
+                .Where(typeof(ManagedType).IsAssignableFrom)
+                .ToList();
+            foreach (var managedType in managedTypes)
+            {
+                var slots = managedType.GetMethods(BindingFlags.Public | BindingFlags.Static);
+                foreach(var slot in slots)
+                    if (!present.Contains(slot.Name))
+                        missing.Add(slot.Name);
+            }
+            foreach (string notSlot in new[]
+            {
+                "__instancecheck__",
+                "__subclasscheck__",
+                "_AtExit",
+                "AddReference",
+                "FinalizeObject",
+                "FindAssembly",
+                "get_SuppressDocs",
+                "get_SuppressOverloads",
+                "GetClrType",
+                "getPreload",
+                "Initialize",
+                "ListAssemblies",
+                "Release",
+                "Reset",
+                "set_SuppressDocs",
+                "set_SuppressOverloads",
+                "setPreload",
+            })
+                missing.Remove(notSlot);
+
+            Debug.Assert(missing.Count == 0,
+                         "Missing slots: " + string.Join(", ", missing));
+        }
     }
 }
