Fix table diff versioned information

pablogsal · pablogsal · commit abe1c884fffe · 2025-06-26T00:11:59.000+01:00
diff --git a/backend/app/routers/benchmarks.py b/backend/app/routers/benchmarks.py
@@ -197,7 +197,7 @@ async def get_batch_benchmark_trends(
     results = {}
 
     for trend_query in request.trend_queries:
-        key = f"{trend_query.binary_id}:{trend_query.benchmark_name}"
+        key = f"{trend_query.binary_id}:{trend_query.benchmark_name}|{trend_query.python_major}.{trend_query.python_minor}"
         trends = await crud.get_benchmark_trends(
             db,
             benchmark_name=trend_query.benchmark_name,
diff --git a/frontend/src/app/build-comparison/page.tsx b/frontend/src/app/build-comparison/page.tsx
@@ -274,7 +274,9 @@ export default function BuildComparisonPage() {
         const newTrendData: Record<string, Record<string, TrendDataPoint[]>> = {};
 
         for (const [key, trends] of Object.entries(batchResponse.results)) {
-          const [binaryId, benchmarkName] = key.split(':');
+          // Extract binary ID and benchmark name from key: format is "binaryId:benchmarkName|pythonVersion"
+          let benchmarkPart = key.split('|')[0]; // Remove python version part
+          const [binaryId, benchmarkName] = benchmarkPart.split(':'); // Extract binary ID and benchmark name
           if (!newTrendData[binaryId]) {
             newTrendData[binaryId] = {};
           }
diff --git a/frontend/src/app/trends/page.tsx b/frontend/src/app/trends/page.tsx
@@ -309,7 +309,9 @@ export default function BenchmarkTrendPage() {
         const newTrendData: Record<string, TrendDataPoint[]> = {};
 
         for (const [key, trends] of Object.entries(batchResponse.results)) {
-          const [, benchmarkName] = key.split(':');
+          // Extract benchmark name from key: format is "binaryId:benchmarkName|pythonVersion"
+          let benchmarkPart = key.split('|')[0]; // Remove python version part
+          const [, benchmarkName] = benchmarkPart.split(':'); // Extract benchmark name
           newTrendData[benchmarkName] = trends;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,9 @@ export default function BenchmarkTrendPage() {`
`309`	`309`	`const newTrendData: Record<string, TrendDataPoint[]> = {};`
`310`	`310`
`311`	`311`	`for (const [key, trends] of Object.entries(batchResponse.results)) {`
`312`		`- const [, benchmarkName] = key.split(':');`
	`312`	`+ // Extract benchmark name from key: format is "binaryId:benchmarkName\|pythonVersion"`
	`313`	`+ let benchmarkPart = key.split('\|')[0]; // Remove python version part`
	`314`	`+ const [, benchmarkName] = benchmarkPart.split(':'); // Extract benchmark name`
`313`	`315`	`newTrendData[benchmarkName] = trends;`
`314`	`316`	`}`
`315`	`317`