fix: type issues (flekschas#157)

flekschas · web-flow · commit b02816a83fa9 · 2023-11-03T11:22:26.000-04:00
* Add `d3-scale` as dev dependencies

* Switch to ubuntu in the hope it fixes the sed issue

* Update CHANGELOG.md

* Split up build and test jobs
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -8,22 +8,24 @@ on:
 
 jobs:
   build:
-    runs-on: macos-latest
-
-    strategy:
-      matrix:
-        node-version: [18.x]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18
+      - run: npm ci
+      - run: npm run build --if-present
+        env:
+          CI: true
 
+  test:
+    runs-on: macos-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
-      - name: Install regl-scatterplot
-        run: npm ci
-      - name: Build regl-scatterplot
-        run: npm run build --if-present
-      - name: Test regl-scatterplot
-        run: npm test
+          node-version: 18
+      - run: npm ci
+      - run: npm test
+        timeout-minutes: 5
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -20,7 +20,7 @@ jobs:
 
   publish-npm:
     needs: build
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -8,7 +8,7 @@ on:
 jobs:
   build:
     name: Create Release
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.8.5
+
+- Fix: add `d3-scale` types as a dev dependency [#153](https://github.com/flekschas/regl-scatterplot/issues/153)
+- Fix: run CI workflows on Ubuntu to ensure the `sed` replacement call works properly [#153](https://github.com/flekschas/regl-scatterplot/issues/153)
+
 ## 1.8.4
 
 - Fix a regression with the point opacity introduced in [v1.7.1](#1.7.1)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
