fixed issues with linters #160 · samghelms/vscode-python@87c66ce · GitHub
Skip to content

Commit 87c66ce

Browse files
DonJayamanneDonJayamanne
committed
fixed issues with linters microsoft#160 
1 parent 2332afb commit 87c66ce

8 files changed

Lines changed: 299 additions & 212 deletions

File tree

‎src/client/common/utils.ts‎

Lines changed: 14 additions & 6 deletions

‎src/client/linters/flake8.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Linter extends baseLinter.BaseLinter {
1919

2020
var flake8Path = this.pythonSettings.linting.flake8Path;
2121
return new Promise<baseLinter.ILintMessage[]>((resolve, reject) => {
22-
this.run(flake8Path, ["--format='%(row)d,%(col)d,%(code)s,%(code)s:%(text)s'", filePath], filePath, txtDocumentLines, this.workspaceRootPath).then(messages => {
22+
this.run(flake8Path, ["--format=%(row)d,%(col)d,%(code)s,%(code)s:%(text)s", filePath], filePath, txtDocumentLines, this.workspaceRootPath).then(messages => {
2323
//All messages in pep8 are treated as warnings for now
2424
messages.forEach(msg => {
2525
msg.severity = baseLinter.LintMessageSeverity.Information;

‎src/client/linters/pep8Linter.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Linter extends baseLinter.BaseLinter {
1919

2020
var pep8Path = this.pythonSettings.linting.pep8Path;
2121
return new Promise<baseLinter.ILintMessage[]>(resolve => {
22-
this.run(pep8Path, ["--format='%(row)d,%(col)d,%(code)s,%(code)s:%(text)s'", filePath], filePath, txtDocumentLines, this.workspaceRootPath).then(messages => {
22+
this.run(pep8Path, ["--format=%(row)d,%(col)d,%(code)s,%(code)s:%(text)s", filePath], filePath, txtDocumentLines, this.workspaceRootPath).then(messages => {
2323
//All messages in pep8 are treated as warnings for now
2424
messages.forEach(msg => {
2525
msg.severity = baseLinter.LintMessageSeverity.Information;

‎src/test/extension.common.test.ts‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
1-
//
2-
// Note: This example test is leveraging the Mocha test framework.
3-
// Please refer to their documentation on https://mochajs.org/ for help.
4-
//
1+
// //
2+
// // Note: This example test is leveraging the Mocha test framework.
3+
// // Please refer to their documentation on https://mochajs.org/ for help.
4+
// //
55

6-
// The module 'assert' provides assertion methods from node
7-
import * as assert from "assert";
6+
// // The module 'assert' provides assertion methods from node
7+
// import * as assert from "assert";
88

9-
// You can import and use all API from the 'vscode' module
10-
// as well as import your extension to test it
11-
import * as vscode from "vscode";
12-
import {execPythonFile} from "../client/common/utils";
13-
import {initialize} from "./initialize";
9+
// // You can import and use all API from the 'vscode' module
10+
// // as well as import your extension to test it
11+
// import * as vscode from "vscode";
12+
// import {execPythonFile} from "../client/common/utils";
13+
// import {initialize} from "./initialize";
1414

15-
// Defines a Mocha test suite to group tests of similar kind together
16-
suite("ChildProc", () => {
17-
setup(done => {
18-
initialize().then(() => done(), done);
19-
});
20-
test("Standard Response", done => {
21-
execPythonFile("python", ["-c", "print(1)"], __dirname, false).then(data => {
22-
assert.ok(data === "1\n");
23-
}).then(done, done);
24-
});
25-
test("Error Response", done => {
26-
execPythonFile("python", ["-c", "print(1"], __dirname, false).then(data => {
27-
assert.ok(false);
28-
}).catch(() => {
29-
assert.ok(true);
30-
}).then(done, done);
31-
});
32-
});
15+
// // Defines a Mocha test suite to group tests of similar kind together
16+
// suite("ChildProc", () => {
17+
// setup(done => {
18+
// initialize().then(() => done(), done);
19+
// });
20+
// test("Standard Response", done => {
21+
// execPythonFile("python", ["-c", "print(1)"], __dirname, false).then(data => {
22+
// assert.ok(data === "1\n");
23+
// }).then(done, done);
24+
// });
25+
// test("Error Response", done => {
26+
// execPythonFile("python", ["-c", "print(1"], __dirname, false).then(data => {
27+
// assert.ok(false);
28+
// }).catch(() => {
29+
// assert.ok(true);
30+
// }).then(done, done);
31+
// });
32+
// });

‎src/test/extension.format.test.ts‎

Lines changed: 105 additions & 105 deletions

0 commit comments

Comments
 (0)