gh-151436: Fix missing `tstate->last_profiled_frame` updates (#151437) · python/cpython@a8d74c0 · GitHub
Skip to content

Commit a8d74c0

Browse files
authored
gh-151436: Fix missing tstate->last_profiled_frame updates (#151437)
1 parent eff805b commit a8d74c0

8 files changed

Lines changed: 33 additions & 8 deletions

File tree

Include/internal/pycore_interpframe.h

Lines changed: 14 additions & 0 deletions
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Fix skewed stack trackes in the Tachyon profiler when caching is enabled and
2+
when generators and coroutines are profiled, by updating
3+
``tstate->last_profiled_frame`` at every frame-removal site. The issue resulted
4+
in total erasure of some callers. Patch by Maurycy Pawłowski-Wieroński.

Modules/_testinternalcapi/test_cases.c.h

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Objects/genobject.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ gen_clear_frame(PyGenObject *gen)
168168
{
169169
assert(FT_ATOMIC_LOAD_INT8_RELAXED(gen->gi_frame_state) == FRAME_CLEARED);
170170
_PyInterpreterFrame *frame = &gen->gi_iframe;
171+
_PyThreadState_UpdateLastProfiledFrame(_PyThreadState_GET(), frame, frame->previous);
171172
frame->previous = NULL;
172173
_PyFrame_ClearExceptCode(frame);
173174
_PyErr_ClearExcState(&gen->gi_exc_state);
@@ -681,6 +682,7 @@ _gen_throw(PyGenObject *gen, int close_on_genexit,
681682
'yield from' or awaiting on with 'await'. */
682683
ret = _gen_throw((PyGenObject *)yf, close_on_genexit,
683684
typ, val, tb);
685+
_PyThreadState_UpdateLastProfiledFrame(tstate, frame, prev);
684686
tstate->current_frame = prev;
685687
frame->previous = NULL;
686688
}
@@ -701,6 +703,7 @@ _gen_throw(PyGenObject *gen, int close_on_genexit,
701703
frame->previous = prev;
702704
tstate->current_frame = frame;
703705
ret = PyObject_CallFunctionObjArgs(meth, typ, val, tb, NULL);
706+
_PyThreadState_UpdateLastProfiledFrame(tstate, frame, prev);
704707
tstate->current_frame = prev;
705708
frame->previous = NULL;
706709
Py_DECREF(meth);

Python/bytecodes.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1860,6 +1860,7 @@ dummy_func(
18601860
gen->gi_exc_state.previous_item = NULL;
18611861
_Py_LeaveRecursiveCallPy(tstate);
18621862
_PyInterpreterFrame *gen_frame = frame;
1863+
_PyThreadState_UpdateLastProfiledFrame(tstate, gen_frame, gen_frame->previous);
18631864
frame = tstate->current_frame = frame->previous;
18641865
gen_frame->previous = NULL;
18651866
((_PyThreadStateImpl *)tstate)->generator_return_kind = GENERATOR_YIELD;
@@ -5874,6 +5875,7 @@ dummy_func(
58745875
gen_frame->owner = FRAME_OWNED_BY_GENERATOR;
58755876
_Py_LeaveRecursiveCallPy(tstate);
58765877
_PyInterpreterFrame *prev = frame->previous;
5878+
_PyThreadState_UpdateLastProfiledFrame(tstate, frame, prev);
58775879
_PyThreadState_PopFrame(tstate, frame);
58785880
frame = tstate->current_frame = prev;
58795881
LOAD_IP(frame->return_offset);

Python/ceval.c

Lines changed: 2 additions & 8 deletions

Python/executor_cases.c.h

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)