{{ message }}
Repository navigation
fix: Fix async main function type - #1672
Merged
Merged
Conversation
This should better reflect the already allowed async function as main
kammerjaeger
changed the title
AaronDewes
approved these changes
May 4, 2022
Contributor
Author
Collaborator
|
It seems correct: Line 76 in 3219a98 @gr2m |
Contributor
Why target beta? We do support it in current Probot, or am I missing something? Lines 72 to 74 in 7b09369 |
Collaborator
|
Yes, main is valid target. |
Member
|
@gr2m I can't merge this either, but I don't see any reason not to merge it. |
Merged
|
🎉 This PR is included in version 12.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should better reflect the already allowed async function as main function in a probot app.
Let me know what you think.