{{ message }}
Repository navigation
Unexpected embedded formatting for Angular template #15969
Description
Prettier 3.2.4
Playground link
--parser babelInput:
const template = "foobar";
@Component({
[template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}Output:
const template = "foobar";
@Component({
[template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}Expected output:
const template = "foobar";
@Component({
[template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}Why?
Prettier formats the content of the template field in Angular's @Component decorator as HTML. However, it now also formats the content of a different field named template as HTML. This isn't expected.
I think adding !node.computed to
prettier/src/language-js/embed/utils.js
Lines 47 to 51 in 4b1965a
Activity
JounQin commentedon Jan 21, 2024
Seems easy to fix.
fix: do not format computed template which could be unexpected
fix: do not format computed template which could be unexpected
JounQin commentedon Jan 22, 2024
@sosukesuzuki Here you are #15972
sosukesuzuki commentedon Jan 23, 2024
@JounQin Thank you for working on this!