Completion with no key #2875

bplaquevent · 2025-04-18T18:34:43Z

bplaquevent
Apr 18, 2025

Hey,
I'm currently trying to set up a new development environment with neovim + lsp-config + phpactor + nvim-cmp.
I noticed that lsp completion does not return anything when I trigger it immédiatly after a trigget character sequence.
I mean : if I type <C-Space> when the cursor is right after a '->' operator, the rpc response is empty.
I spent a lot of time trying to figure out id thers is a way to get the whole list of methods and property of an object that way but didnt find aything.

Here is an example :

<?php                                                                                                                                                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                                                                                                                                                           
namespace App;                                                                                                                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                                                                                           
class User                                                                                                                                                                                                                                                                                                                                                                 
{                                                                                                                                                                                                                                                                                                                                                                          
    public function get(string $param): string                                                                                                                                                                                                                                                                                                                             
    {                                                                                                                                                                                                                                                                                                                                                                      
        return $param;                                                                                                                                                                                                                                                                                                                                                     
    }                                                                                                                                                                                                                                                                                                                                                                      
}                                                                                                                                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                                                                                                                           
$user = new User();                                                                                                                                                                                                                                                                                                                                                        
$user->

<C-Space> triggers a RPC request but the reponse is empty (result = { isIncomplete = true, items = {} })

<?php                                                                                                                                                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                                                                                                                                                           
namespace App;                                                                                                                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                                                                                           
class User                                                                                                                                                                                                                                                                                                                                                                 
{                                                                                                                                                                                                                                                                                                                                                                          
    public function get(string $param): string                                                                                                                                                                                                                                                                                                                             
    {                                                                                                                                                                                                                                                                                                                                                                      
        return $param;                                                                                                                                                                                                                                                                                                                                                     
    }                                                                                                                                                                                                                                                                                                                                                                      
}                                                                                                                                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                                                                                                                           
$user = new User();                                                                                                                                                                                                                                                                                                                                                        
$user->g

When adding a first character after the -> operator, <C-Space> triggers a RPC request and the reponse contains the correct items.

I can reproduce with $ and ::.

I wonder if that's an intended behavior to optimize performance or if I miss something.
On the https://github.com/phpactor/ncm2-phpactor page, the gif seems to show that the completion shouldn't need an extra char after operator.

I spent a full afternoon to unsuccessfully search for an answer.
So could you please tell me if there's a way to achieve completion without extra char or not.

(I use neovim 0.11 with up to date lsp-config and nvim-cmp plugins and phpactor 2025.04.17.0)

Answered by bplaquevent

Apr 25, 2025

OMG, found !!!
php-mbstring was missing.
Thank you @mamazu & @dantleech for you help.
Glad I was finally able to find the source of the problem. This was driving me crazy.

View full answer

dantleech · 2025-04-18T19:41:49Z

dantleech
Apr 18, 2025
Maintainer

If you're using LSP you do not need to use ncm2 or the "legacy" RPC protocol.

I use https://github.com/hrsh7th/nvim-cmp for completion and I don't have ctrl-<space> or <tab> or whatever configured - it's automatic:

3 replies

bplaquevent Apr 22, 2025
Author

Doesn't the LSP server use the RPC protocol to submit completion request to phpactor?
Because I dont use the RPC protocol by myself, just set up lsp-config to use php-actor and nvim-cmp for autocompletion.
The RPC traces come from my lsp.log file.

dantleech Apr 22, 2025
Maintainer

it uses an RPC protocol - JSON-RPC. You mentioned ncm2 which uses/used Phpactor's own (legacy) RPC protocol/mechanism. NCM2 is pre-LSP.

bplaquevent Apr 22, 2025
Author

Oh I see. Sorry for the confusion.
I was not aware phpactor implements diffrent RPC interfaces.
The RPC response I quoted comes from my lsp.log so, according to what you say, I guess this is a JSON-RPC response.
I mentioned NCM2 only because the gif on the project homepage tends to show that completion should work even without typing anything after an opertaor. But it seems unrevelant as you inform me that NCM2 uses another RPC interface.
Finally, we seem to have a similar config (with nvim-cmp) but I still cant figure out why I am unable to get completion without typing anything after an operator.
By any chance, could you please share a sample of your config?

mamazu · 2025-04-19T09:45:51Z

mamazu
Apr 19, 2025

Do you happen to have a link to your dot files? I'd be happy to take a look.

4 replies

bplaquevent Apr 22, 2025
Author

It's something I had to do, it's the right time I think :)
https://github.com/bplaquevent/home/tree/main/.config/nvim

mamazu Apr 23, 2025

Opened an issue and added some context:

bplaquevent/home#1

bplaquevent Apr 24, 2025
Author

Thank you a lot for the time you spent on this.
But I'm sorry, I think my explaination was not clear.
The problem I try to solve is not about having to hit a key to trigger completion, but about to be unable to trigger completion if I don't have any method or property start character.
With $this->, completion doesn't offer any suggestion, where $this->g does. (when I enable other completions sources like buffer or path, I see only suggestions related to these sources with $this->, LSP source suggestions appears only after $this->g)
I tried to remove the autocomplete=false (that I added on purpose) and that just makes completion window appear witout having to hit <C-Space> but still no completion window right after $this-> when $this->g does make completion window appear.
I checked my lsp.log file and I see a RPC request to phpactor but the response is empty for after $this-> (completion is triggered but no suggestion is returned by phpactor) when it contains suggestions after $this->g.

mamazu Apr 24, 2025

Hm okay that's a different problem but I can't reproduce that. (Even with manual completion enabled.)

Maybe something is wrong with your phpactor installation. With a fresh install of phpactor it works. Very strange.

bplaquevent · 2025-04-25T13:45:54Z

bplaquevent
Apr 25, 2025
Author

0 replies

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Completion with no key #2875

Uh oh!

bplaquevent Apr 18, 2025

Replies: 3 comments · 7 replies

Uh oh!

Uh oh!

dantleech Apr 18, 2025 Maintainer

Uh oh!

Uh oh!

bplaquevent Apr 22, 2025 Author

Uh oh!

Uh oh!

dantleech Apr 22, 2025 Maintainer

Uh oh!

bplaquevent Apr 22, 2025 Author

Uh oh!

mamazu Apr 19, 2025

Uh oh!

bplaquevent Apr 22, 2025 Author

Uh oh!

mamazu Apr 23, 2025

Uh oh!

Uh oh!

bplaquevent Apr 24, 2025 Author

Uh oh!

mamazu Apr 24, 2025

Uh oh!

bplaquevent Apr 25, 2025 Author

bplaquevent
Apr 18, 2025

Replies: 3 comments 7 replies

dantleech
Apr 18, 2025
Maintainer

bplaquevent Apr 22, 2025
Author

dantleech Apr 22, 2025
Maintainer

bplaquevent Apr 22, 2025
Author

mamazu
Apr 19, 2025

bplaquevent Apr 22, 2025
Author

bplaquevent Apr 24, 2025
Author

bplaquevent
Apr 25, 2025
Author