{{ message }}
Repository navigation
fix(vite,nitro): link null-byte virtual css through /@id/ in dev - #36549
Merged
Merged
Conversation
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/vite-server
@nuxt/webpack-builder
commit: |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughCSS collection in Nitro SSR and Vite now converts module IDs to Vite development URLs. Tests cover path-based, wrapped, virtual, and NUL-prefixed IDs. A development fixture registers a NUL-prefixed virtual stylesheet, and an integration test checks its rendered URL and CSS response. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The change appears ready to merge after normal checks; no actionable merge-blocking risk was identified. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
with
@unocss/nuxtin dev, the SSR HTML contains a stylesheet link with a literal NUL byte in it:the HTML tokenizer replaces the NUL with U+FFFD, so the browser requests
/_nuxt/%EF%BF%BD/__uno.css- and uno happens to resolve that by suffix, but it means there are two copies of its stylesheet injected.this PR maps non-path ids to
/@id/(with\0as__x00__) before they become links, the same way Vite itself does. this also applies to bare virtual ids likevirtual:foo.css, which only happened to work before....