{{ message }}
feat: port test_exception to CTS#43
Draft
bavulapati wants to merge 10 commits into
Draft
Conversation
Contributor
Author
Member
|
This one is tricky, as I don't expect implementors such as emnapi and React Native to support this from their harness implementation 🤔 |
Contributor
Author
|
@kraenhansen A priority list would have helped. I'm just picking up from the list sequentially. |
Contributor
Author
|
depends on #54 |
Member
# Conflicts: # eslint.config.js # implementors/node/tests.ts
Replace the POSIX-specific signal field with an aborted boolean computed by the Node implementor, moving the abort exit-code knowledge out of portable tests and into child_process.js.
A bare 'file://' + path is malformed on Windows (file://C:\...). Also surface aborts in the failure reason regardless of exit code.
bavulapati
force-pushed
the
feat/port-test-exception
branch
from
4dfac05 to
94d6582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ports
test_exception from Node.js test suite to the CTS.