src: add ExecutionAsyncId getter for any Context

szegedi · aduh95 · commit e1d3a9e19258 · 2025-05-19T12:13:59.000+02:00
Adds a variant of AsyncHooksGetExecutionAsyncId that takes a V8 Context and returns the async ID belonging to the Environment (if any) of that Context. Sometimes we want to use Isolate::GetEnteredOrMicrotaskContext insteads of Isolate::GetCurrentContext (e.g. recording the async ID in a V8 GC prologue callback) when current context is not set. PR-URL: #57820 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/src/api/hooks.cc b/src/api/hooks.cc
@@ -196,6 +196,12 @@ async_id AsyncHooksGetExecutionAsyncId(Isolate* isolate) {
   return env->execution_async_id();
 }
 
+async_id AsyncHooksGetExecutionAsyncId(Local<Context> context) {
+  Environment* env = Environment::GetCurrent(context);
+  if (env == nullptr) return -1;
+  return env->execution_async_id();
+}
+
 async_id AsyncHooksGetTriggerAsyncId(Isolate* isolate) {
   Environment* env = Environment::GetCurrent(isolate);
   if (env == nullptr) return -1;
diff --git a/src/node.h b/src/node.h
@@ -1387,6 +1387,12 @@ NODE_EXTERN void RequestInterrupt(Environment* env,
  * I/O from native code. */
 NODE_EXTERN async_id AsyncHooksGetExecutionAsyncId(v8::Isolate* isolate);
 
+/* Returns the id of the current execution context. If the return value is
+ * zero then no execution has been set. This will happen if the user handles
+ * I/O from native code. */
+NODE_EXTERN async_id
+AsyncHooksGetExecutionAsyncId(v8::Local<v8::Context> context);
+
 /* Return same value as async_hooks.triggerAsyncId(); */
 NODE_EXTERN async_id AsyncHooksGetTriggerAsyncId(v8::Isolate* isolate);
 
diff --git a/test/addons/async-hooks-id/binding.cc b/test/addons/async-hooks-id/binding.cc
@@ -12,13 +12,21 @@ void GetExecutionAsyncId(const FunctionCallbackInfo<Value>& args) {
     node::AsyncHooksGetExecutionAsyncId(args.GetIsolate()));
 }
 
+void GetExecutionAsyncIdWithContext(const FunctionCallbackInfo<Value>& args) {
+  args.GetReturnValue().Set(node::AsyncHooksGetExecutionAsyncId(
+      args.GetIsolate()->GetCurrentContext()));
+}
+
 void GetTriggerAsyncId(const FunctionCallbackInfo<Value>& args) {
   args.GetReturnValue().Set(
     node::AsyncHooksGetTriggerAsyncId(args.GetIsolate()));
 }
 
 void Initialize(Local<Object> exports) {
   NODE_SET_METHOD(exports, "getExecutionAsyncId", GetExecutionAsyncId);
+  NODE_SET_METHOD(exports,
+                  "getExecutionAsyncIdWithContext",
+                  GetExecutionAsyncIdWithContext);
   NODE_SET_METHOD(exports, "getTriggerAsyncId", GetTriggerAsyncId);
 }
 
diff --git a/test/addons/async-hooks-id/test.js b/test/addons/async-hooks-id/test.js
@@ -9,6 +9,10 @@ assert.strictEqual(
   binding.getExecutionAsyncId(),
   async_hooks.executionAsyncId(),
 );
+assert.strictEqual(
+  binding.getExecutionAsyncIdWithContext(),
+  async_hooks.executionAsyncId(),
+);
 assert.strictEqual(
   binding.getTriggerAsyncId(),
   async_hooks.triggerAsyncId(),
@@ -19,6 +23,10 @@ process.nextTick(common.mustCall(() => {
     binding.getExecutionAsyncId(),
     async_hooks.executionAsyncId(),
   );
+  assert.strictEqual(
+    binding.getExecutionAsyncIdWithContext(),
+    async_hooks.executionAsyncId(),
+  );
   assert.strictEqual(
     binding.getTriggerAsyncId(),
     async_hooks.triggerAsyncId(),

Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,21 @@ void GetExecutionAsyncId(const FunctionCallbackInfo<Value>& args) {`
`12`	`12`	`node::AsyncHooksGetExecutionAsyncId(args.GetIsolate()));`
`13`	`13`	`}`
`14`	`14`
	`15`	`+void GetExecutionAsyncIdWithContext(const FunctionCallbackInfo<Value>& args) {`
	`16`	`+ args.GetReturnValue().Set(node::AsyncHooksGetExecutionAsyncId(`
	`17`	`+ args.GetIsolate()->GetCurrentContext()));`
	`18`	`+}`
	`19`	`+`
`15`	`20`	`void GetTriggerAsyncId(const FunctionCallbackInfo<Value>& args) {`
`16`	`21`	`args.GetReturnValue().Set(`
`17`	`22`	`node::AsyncHooksGetTriggerAsyncId(args.GetIsolate()));`
`18`	`23`	`}`
`19`	`24`
`20`	`25`	`void Initialize(Local<Object> exports) {`
`21`	`26`	`NODE_SET_METHOD(exports, "getExecutionAsyncId", GetExecutionAsyncId);`
	`27`	`+ NODE_SET_METHOD(exports,`
	`28`	`+ "getExecutionAsyncIdWithContext",`
	`29`	`+ GetExecutionAsyncIdWithContext);`
`22`	`30`	`NODE_SET_METHOD(exports, "getTriggerAsyncId", GetTriggerAsyncId);`
`23`	`31`	`}`
`24`	`32`