doc: update devcontainer.json and add documentation · nodejs/node@cd323bc · GitHub
Skip to content

Commit cd323bc

Browse files
joyeecheungaduh95
authored andcommitted
doc: update devcontainer.json and add documentation
The previous .devcontainer.json configuration was outdated and contained personal configurations that were not needed to run a dev container. This updates the structure so that it's put in .devcontainer/base/devcontainer.json based on the recommended setup in GitHub's documentation. The official image now publishes both arm64 and amd64 images, and devcontainer tools should be able to pick up the right one without extra arguments. This also adds documentation on how to use the container. Refs: https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers#devcontainerjson PR-URL: #60472 Refs: https://github.com/nodejs/devcontainer Refs: https://hub.docker.com/r/nodejs/devcontainer Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 402d9f8 commit cd323bc

5 files changed

Lines changed: 153 additions & 26 deletions

File tree

.devcontainer.json

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions

.github/CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,3 +231,7 @@
231231

232232
# userland-migrations
233233
/doc/api/deprecations.md @nodejs/userland-migrations
234+
235+
# dev container
236+
/.devcontainer/* @nodejs/devcontainer
237+
/doc/contributing/using-devcontainer.md @nodejs/devcontainer

.gitignore

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
.*
88
# Exclude specific dotfiles that we want to track.
99
!deps/**/.*
10-
!.devcontainer.json
1110
!test/fixtures/**/.*
1211
!.clang-format
1312
!.cpplint
@@ -167,3 +166,10 @@ __pycache__
167166

168167
# === Rules for C++ development ===
169168
compile_commands.json
169+
170+
# === Dev Container rules ===
171+
# Only track the shared base devcontainer.json; ignore everything else under .devcontainer
172+
!.devcontainer/
173+
.devcontainer/**
174+
!.devcontainer/base/
175+
!.devcontainer/base/devcontainer.json
Lines changed: 131 additions & 0 deletions

0 commit comments

Comments
 (0)