process: remove support for undocumented symbol

aduh95 · aduh95 · commit c78e11064f87 · 2025-02-06T01:10:44.000+01:00
PR-URL: #56552 Backport-PR-URL: #56571 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -424,15 +424,17 @@ function toggleTraceCategoryState(asyncHooksEnabled) {
 
 const { arch, platform, version } = process;
 
+let refSymbol;
 function ref(maybeRefable) {
-  const fn = maybeRefable?.[SymbolFor('nodejs.ref')] || maybeRefable?.[SymbolFor('node:ref')] || maybeRefable?.ref;
+  if (maybeRefable == null) return;
+  const fn = maybeRefable[refSymbol ??= SymbolFor('nodejs.ref')] || maybeRefable.ref;
   if (typeof fn === 'function') FunctionPrototypeCall(fn, maybeRefable);
 }
 
+let unrefSymbol;
 function unref(maybeRefable) {
-  const fn = maybeRefable?.[SymbolFor('nodejs.unref')] ||
-             maybeRefable?.[SymbolFor('node:unref')] ||
-             maybeRefable?.unref;
+  if (maybeRefable == null) return;
+  const fn = maybeRefable[unrefSymbol ??= SymbolFor('nodejs.unref')] || maybeRefable.unref;
   if (typeof fn === 'function') FunctionPrototypeCall(fn, maybeRefable);
 }
 
diff --git a/test/parallel/test-process-ref-unref.js b/test/parallel/test-process-ref-unref.js
@@ -33,37 +33,20 @@ class Foo2 {
   }
 }
 
-// TODO(aduh95): remove support for undocumented symbol
-class Foo3 {
-  refCalled = 0;
-  unrefCalled = 0;
-  [Symbol.for('node:ref')]() {
-    this.refCalled++;
-  }
-  [Symbol.for('node:unref')]() {
-    this.unrefCalled++;
-  }
-}
-
 describe('process.ref/unref work as expected', () => {
   it('refs...', () => {
     // Objects that implement the new Symbol-based API
     // just work.
     const foo1 = new Foo();
     const foo2 = new Foo2();
-    const foo3 = new Foo3();
     process.ref(foo1);
     process.unref(foo1);
     process.ref(foo2);
     process.unref(foo2);
-    process.ref(foo3);
-    process.unref(foo3);
     strictEqual(foo1.refCalled, 1);
     strictEqual(foo1.unrefCalled, 1);
     strictEqual(foo2.refCalled, 1);
     strictEqual(foo2.unrefCalled, 1);
-    strictEqual(foo3.refCalled, 1);
-    strictEqual(foo3.unrefCalled, 1);
 
     // Objects that implement the legacy API also just work.
     const i = setInterval(() => {}, 1000);
