lib: remove lib/internal/idna.js

anonrig · marco-ippolito · commit 8e6b606ac45f · 2024-11-17T11:51:36.000+01:00
PR-URL: #55050 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
diff --git a/lib/internal/idna.js b/lib/internal/idna.js
diff --git a/lib/url.js b/lib/url.js
@@ -30,7 +30,7 @@ const {
   decodeURIComponent,
 } = primordials;
 
-const { toASCII } = require('internal/idna');
+const { toASCII } = internalBinding('encoding_binding');
 const { encodeStr, hexTable } = require('internal/querystring');
 const querystring = require('querystring');
 
diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -113,7 +113,6 @@ expected.atRunTime = new Set([
 
 if (common.isMainThread) {
   [
-    'NativeModule internal/idna',
     'NativeModule url',
   ].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));
 } else {  // Worker.

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,6 @@ expected.atRunTime = new Set([`
`113`	`113`
`114`	`114`	`if (common.isMainThread) {`
`115`	`115`	`[`
`116`		`- 'NativeModule internal/idna',`
`117`	`116`	`'NativeModule url',`
`118`	`117`	`].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));`
`119`	`118`	`} else { // Worker.`