permission: remove useless conditional

juanarbol · aduh95 · commit 6fd1b2326024 · 2025-06-10T15:10:13.000+02:00
Deleting a null pointer has no effect. The check is not needed. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #58514 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -45,9 +45,7 @@ void FreeRecursivelyNode(
     }
   }
 
-  if (node->wildcard_child != nullptr) {
-    delete node->wildcard_child;
-  }
+  delete node->wildcard_child;
   delete node;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,7 @@ void FreeRecursivelyNode(`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`- if (node->wildcard_child != nullptr) {`
`49`		`- delete node->wildcard_child;`
`50`		`- }`
	`48`	`+ delete node->wildcard_child;`
`51`	`49`	`delete node;`
`52`	`50`	`}`
`53`	`51`