test_runner: fix passing expectFailure

MoLow · aduh95 · commit 6a4de694b208 · 2026-02-22T23:16:13.000+01:00
PR-URL: #61568 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -82,6 +82,7 @@ const kParentAlreadyFinished = 'parentAlreadyFinished';
 const kSubtestsFailed = 'subtestsFailed';
 const kTestCodeFailure = 'testCodeFailure';
 const kTestTimeoutFailure = 'testTimeoutFailure';
+const kExpectedFailure = 'expectedFailure';
 const kHookFailure = 'hookFailed';
 const kDefaultTimeout = null;
 const noop = FunctionPrototype;
@@ -957,6 +958,14 @@ class Test extends AsyncResource {
   }
 
   pass() {
+    if (this.error == null && this.expectFailure === true && !this.skipped) {
+      this.passed = false;
+      this.error = new ERR_TEST_FAILURE(
+        'test was expected to fail but passed',
+        kExpectedFailure,
+      );
+      return;
+    }
     if (this.error !== null) {
       return;
     }
diff --git a/test/parallel/test-runner-expect-error-but-pass.js b/test/parallel/test-runner-expect-error-but-pass.js
@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+const assert = require('node:assert');
+const { run, test } = require('node:test');
+
+if (!process.env.NODE_TEST_CONTEXT) {
+  const stream = run({ files: [__filename] });
+
+  stream.on('test:pass', common.mustNotCall());
+  stream.on('test:fail', common.mustCall((event) => {
+    assert.strictEqual(event.expectFailure, true);
+    assert.strictEqual(event.details.error.code, 'ERR_TEST_FAILURE');
+    assert.strictEqual(event.details.error.failureType, 'expectedFailure');
+    assert.strictEqual(event.details.error.cause, 'test was expected to fail but passed');
+  }, 1));
+} else {
+  test('passing test', { expectFailure: true }, () => {});
+}
diff --git a/test/parallel/test-runner-expect-error.js b/test/parallel/test-runner-expect-error.js
@@ -0,0 +1,15 @@
+'use strict';
+const common = require('../common');
+const assert = require('node:assert');
+const { run, test } = require('node:test');
+
+if (!process.env.NODE_TEST_CONTEXT) {
+  const stream = run({ files: [__filename] });
+
+  stream.on('test:fail', common.mustNotCall());
+  stream.on('test:pass', common.mustCall((event) => {
+    assert.strictEqual(event.expectFailure, true);
+  }, 1));
+} else {
+  test('failing test', { expectFailure: true }, () => assert.fail('should not pass'));
+}
