build: define V8_CONTIGUOUS_COMPRESSED_RO_SPACE for shared cage · nodejs/node@676e15c · GitHub
Skip to content

Commit 676e15c

Browse files
codebytereaduh95
authored andcommitted
build: define V8_CONTIGUOUS_COMPRESSED_RO_SPACE for shared cage
Since the V8 14.2 update, `globals.h` sizes the read-only space reservation in the shared pointer compression cage from `V8_CONTIGUOUS_COMPRESSED_RO_SPACE_SIZE_MB`, which BUILD.gn defines together with `V8_CONTIGUOUS_COMPRESSED_RO_SPACE` whenever `v8_enable_pointer_compression_shared_cage` is set. features.gypi defines neither, so builds configured with `--experimental-pointer-compression-shared-cage` fail to compile V8. Define both the way BUILD.gn does, with the same 16 MB default. Refs: #60254 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65464 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent e0c7ba8 commit 676e15c

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 8 additions & 1 deletion

0 commit comments

Comments
 (0)