Revert "stream: noop pause/resume on destroyed streams"

sxa · sxa · commit 3f54c8ba3261 · 2026-06-18T20:49:14.000+01:00
This reverts commit 29b1966. Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: #63834 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -1233,9 +1233,6 @@ function nReadingNextTick(self) {
 // If the user uses them, then switch into old mode.
 Readable.prototype.resume = function() {
   const state = this._readableState;
-  if ((state[kState] & kDestroyed) !== 0) {
-    return this;
-  }
   if ((state[kState] & kFlowing) === 0) {
     debug('resume');
     // We flow only if there is no one listening
@@ -1276,9 +1273,6 @@ function resume_(stream, state) {
 
 Readable.prototype.pause = function() {
   const state = this._readableState;
-  if ((state[kState] & kDestroyed) !== 0) {
-    return this;
-  }
   debug('call pause');
   if ((state[kState] & (kHasFlowing | kFlowing)) !== kHasFlowing) {
     debug('pause');
diff --git a/test/parallel/test-stream-destroy.js b/test/parallel/test-stream-destroy.js
@@ -118,13 +118,3 @@ const http = require('http');
     req.end('asd');
   }));
 }
-
-{
-  // resume() and pause() should be no-ops on destroyed streams.
-  const r = new Readable({ read() {} });
-  r.destroy();
-  r.on('resume', common.mustNotCall());
-  r.on('pause', common.mustNotCall());
-  r.resume();
-  r.pause();
-}
