{{ message }}
Repository navigation
Simplify DnsQueryContext usage again - #13450
Merged
Merged
Conversation
Motivation: 22bf43b made some changes to simplify DnsQueryContext but did introduce one change which might be a bit error-prone. Modifications: Don't pass the nameserveraddress and the channel to the finish* and writeQuery methods. Result: Always log / use the correct nameserveraddress / channel
normanmaurer
force-pushed
the
cleanup_again
branch
from
June 15, 2023 13:12
3129e22 to
6318287
Compare
normanmaurer
added a commit
that referenced
this pull request
Jun 16, 2023
Motivation: 22bf43b made some changes to simplify DnsQueryContext but did introduce one change which might be a bit error-prone. Modifications: Don't pass the nameserveraddress and the channel to the finish* and writeQuery methods. Result: Always log / use the correct nameserveraddress / channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
22bf43b made some changes to simplify DnsQueryContext but did introduce one change which might be a bit error-prone.
Modifications:
Don't pass the nameserveraddress and the channel to the finish* and writeQuery methods.
Result:
Always log / use the correct nameserveraddress / channel