Fix SDK Already Exists Check for Linux by JacksonWeber · Pull Request #1235 · microsoft/ApplicationInsights-node.js · GitHub
Skip to content

Fix SDK Already Exists Check for Linux#1235

Merged
JacksonWeber merged 2 commits into
microsoft:developfrom
JacksonWeber:jacksonweber/detect-sdk-attach
Oct 27, 2023
Merged

Fix SDK Already Exists Check for Linux#1235
JacksonWeber merged 2 commits into
microsoft:developfrom
JacksonWeber:jacksonweber/detect-sdk-attach

Conversation

@JacksonWeber

@JacksonWeber JacksonWeber commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Based on investigation, the current working directory is not captured by the Node 8.9+ check of the appInstance value in Linux environments. Therefore, we miss the check intended to send a diagnostic log indicating that the SDK had already attached.

@hectorhdzg hectorhdzg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants