{{ message }}
Implement extraction safety for tarfile context - #18
Merged
Merged
Conversation
jaraco
commented
Jan 13, 2026
jaraco
commented
Owner
- Add repro as provided by tsigouris007
- 👹 Feed the hobgoblins (delint).
- Convert the repro to a parameterized unit test.
- Update implementation to have different expectations for different cases.
- In tarfile.context, ensure that the default filter honors the data filter to avoid path traversal vulnerabilities.
- Add another case, demonstrating legitimate use of parent dir.
- Also extract the member, for completeness.
- Use the filter argument to tarfile.extract to avoid the deprecation warning.
…lter to avoid path traversal vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.