fix(jsx): allow JSXNode function component results by icecold009 · Pull Request #5476 · honojs/hono · GitHub
Skip to content

fix(jsx): allow JSXNode function component results - #5476

Merged
yusukebe merged 1 commit into
honojs:mainfrom
icecold009:fix/jsxnode-function-components
Oct 1, 2026
Merged

yusukebe merged 1 commit into
honojs:mainfrom
icecold009:fix/jsxnode-function-components

Conversation

@icecold009

Copy link
Copy Markdown
Contributor

Summary

  • Allow function components to return a JSXNode directly or through a promise, matching the existing renderer behavior.
  • Add a TSX regression case for a component created with jsx() and used as JSX.

Closes #5467.

Verification

  • tsc -p tsconfig.spec.json
  • vitest run src/jsx/base.test.tsx (9 tests passed)
  • Prettier check for the changed files

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe yusukebe changed the title fix: allow JSXNode function component results fix(jsx): allow JSXNode function component results Oct 1, 2026
@yusukebe

yusukebe commented Oct 1, 2026

Copy link
Copy Markdown
Member

@yusukebe
yusukebe merged commit f23b146 into honojs:main Oct 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSX: Allow non-array JSXNode function components

2 participants