Add documentation and test for additionalTypes in GraphQLSchema by andimarek · Pull Request #4208 · graphql-java/graphql-java · GitHub
Skip to content

Add documentation and test for additionalTypes in GraphQLSchema#4208

Merged
andimarek merged 2 commits into
masterfrom
additional-types
Jan 19, 2026
Merged

Add documentation and test for additionalTypes in GraphQLSchema#4208
andimarek merged 2 commits into
masterfrom
additional-types

Conversation

@andimarek

@andimarek andimarek commented Jan 19, 2026

Copy link
Copy Markdown
Member

Clarify additional types purpose.

- Add comprehensive JavaDoc to getAdditionalTypes() explaining when
  additional types are needed (interface implementations, SDL schemas,
  programmatic schemas with type references)
- Add JavaDoc to builder methods additionalTypes(), additionalType(),
  and clearAdditionalTypes()
- Document that there are no restrictions on what types can be added
- Add test demonstrating that additionalTypes accepts any type,
  including types already reachable from root operations
- Add .vscode to .gitignore
@github-actions

github-actions Bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@andimarek andimarek merged commit 2766087 into master Jan 19, 2026
5 checks passed
@andimarek andimarek added the not release related changes which are not released (for example unit tests or docs) label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not release related changes which are not released (for example unit tests or docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants