iframe-proxy

rcleveng · 2025-11-09T22:10:39Z

fix(bucket): url encode new_name parameter in move_blob()

The move_blob() method was not URL encoding the new_name parameter
before passing it to the API call, unlike how the blob encodes its own
path. This caused failures when moving blobs to paths with special
characters.

Added URL encoding for new_name to match the blob path encoding, as
both names must fit in the API URL format: "{blob_path}/moveTo/o/{new_name}"

Here's an example of what fails:

from google.cloud import storage
gcs = storage.Client()
bucket = gcs.bucket("")
blob = bucket.get_blob("test/blob.csv")
bucket.move_blob(
    blob, 
    new_name="test/blob2.csv"
)

Fixes #1523

There's no need to add a test when the name does not need urlencoding since that's already covered in the previous 2 tests for move_blob.

gemini-code-assist · 2025-11-09T22:10:53Z

Summary of Changes

Hello @rcleveng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Google Cloud Storage client library's Bucket#move_blob() function. Previously, attempts to move blobs to a new name containing special characters that required URL encoding would result in an error. The implemented fix ensures that the new_name is properly URL-encoded before constructing the API request path, thereby preventing these failures and significantly improving the robustness and reliability of blob movement operations for a wider array of object names.

Highlights

Bug Fix: Resolves an issue where Bucket#move_blob() failed when the target blob name contained characters that required URL encoding.
URL Encoding: The new_name parameter in the move_blob method is now explicitly URL-encoded using the _quote utility before being used in the API request path.
Test Coverage: A new unit test, test_move_blob_needs_url_encoding, has been added to verify the correct URL encoding behavior for blob move operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly fixes a bug in Bucket.move_blob() where the new blob name was not being URL-encoded, causing failures for names containing special characters like '/'. The fix involves using the existing _quote helper to encode the new_name before constructing the API request path. A new unit test, test_move_blob_needs_url_encoding, has been added to verify this fix and prevent future regressions. The changes are correct, well-tested, and I approve of them.

rcleveng · 2025-11-13T15:28:24Z

Hey @chandra-siri is there anything else I need to do here on this one?

chandra-siri

LGTM.

chandra-siri · 2025-11-18T07:09:50Z

Hey @chandra-siri is there anything else I need to do here on this one?

You need to update the branch and resolve conflicts, if any.
Add systems tests in tests/system/test_bucket.py (you can raise a separate PR , or we'll do it in couple of days)

Thanks for fixing this issue.

chandra-siri · 2025-11-18T07:11:08Z

@rcleveng I've reviewed it now. Thanks for your patience and apologies for the delay.

chandra-siri · 2025-11-18T13:51:23Z

Sys test for move blob. Add System test for bukect.move_blob where blob name needs url encoding. The fix was done in #1605

🤖 I have created a release *beep* *boop* --- ## [3.7.0](v3.6.0...v3.7.0) (2025-12-09) ### Features * Auto enable mTLS when supported certificates are detected ([#1637](#1637)) ([4e91c54](4e91c54)) * Send entire object checksum in the final api call of resumable upload ([#1654](#1654)) ([ddce7e5](ddce7e5)) * Support urllib3 >= 2.6.0 ([#1658](#1658)) ([57405e9](57405e9)) ### Bug Fixes * **bucket:** Move blob fails when the new blob name contains characters that need to be url encoded ([#1605](#1605)) ([ec470a2](ec470a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>

Sys test for move blob. Add System test for bukect.move_blob where blob name needs url encoding. The fix was done in googleapis/python-storage#1605

🤖 I have created a release *beep* *boop* --- ## [3.7.0](googleapis/python-storage@v3.6.0...v3.7.0) (2025-12-09) ### Features * Auto enable mTLS when supported certificates are detected ([#1637](googleapis/python-storage#1637)) ([4e91c54](googleapis/python-storage@4e91c54)) * Send entire object checksum in the final api call of resumable upload ([#1654](googleapis/python-storage#1654)) ([ddce7e5](googleapis/python-storage@ddce7e5)) * Support urllib3 >= 2.6.0 ([#1658](googleapis/python-storage#1658)) ([57405e9](googleapis/python-storage@57405e9)) ### Bug Fixes * **bucket:** Move blob fails when the new blob name contains characters that need to be url encoded ([#1605](googleapis/python-storage#1605)) ([ec470a2](googleapis/python-storage@ec470a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>

rcleveng added 2 commits November 9, 2025 12:43

Encode the blob name when it's being passed to the API path

5c2ebb6

Add a test for a new name that needs URL encoding.

fccfae1

There's no need to add a test when the name does not need urlencoding since that's already covered in the previous 2 tests for move_blob.

rcleveng requested review from a team November 9, 2025 22:10

product-auto-label Bot added the size: s Pull request size is small. label Nov 9, 2025

blunderbuss-gcf Bot assigned chandra-siri Nov 9, 2025

product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 9, 2025

gemini-code-assist Bot reviewed Nov 9, 2025

View reviewed changes

d-bytebase approved these changes Nov 9, 2025

View reviewed changes

rcleveng changed the title ~~Move blob fails when the new blob name contains characters that need to be url encoded~~ fix(bucket): Move blob fails when the new blob name contains characters that need to be url encoded Nov 10, 2025

chandra-siri approved these changes Nov 18, 2025

View reviewed changes

Merge branch 'main' into move_blob

d640618

chandra-siri added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2025

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2025

Pulkit0110 approved these changes Nov 18, 2025

View reviewed changes

chandra-siri added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2025

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2025

chandra-siri merged commit ec470a2 into googleapis:main Nov 18, 2025
15 of 16 checks passed

release-please Bot mentioned this pull request Nov 18, 2025

chore(main): release 3.7.0 #1621

Merged

chandra-siri mentioned this pull request Nov 18, 2025

chore: Add Sys test for move blob where name needs url encoding #1624

Merged

chandra-siri mentioned this pull request Nov 19, 2025

chore: librarian release pull request: 20251119T165746Z #1630

Closed

chandra-siri added a commit that referenced this pull request Nov 26, 2025

chore: Add Sys test for move blob where name needs url encoding (#1624)

fcda233

Sys test for move blob. Add System test for bukect.move_blob where blob name needs url encoding. The fix was done in #1605

vchudnov-g mentioned this pull request Jan 12, 2026

chore: librarian release pull request: 20260112T135255Z #1701

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(bucket): Move blob fails when the new blob name contains characters that need to be url encoded#1605

fix(bucket): Move blob fails when the new blob name contains characters that need to be url encoded#1605
chandra-siri merged 3 commits into
googleapis:mainfrom
rcleveng:move_blob

rcleveng commented Nov 9, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Nov 9, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

rcleveng commented Nov 13, 2025

Uh oh!

chandra-siri left a comment

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

rcleveng commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Nov 9, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

rcleveng commented Nov 13, 2025

Uh oh!

chandra-siri left a comment

Choose a reason for hiding this comment

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

Uh oh!

chandra-siri commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rcleveng commented Nov 9, 2025 •

edited

Loading