{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat(experimental): Handle BidiReadObjectRedirectedError for bidi reads#1600
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a resumption strategy for bidi reads, including handling for BidiReadObjectRedirectedError. The implementation adds a base strategy class, a concrete strategy for reads, and corresponding unit tests. My review has identified a couple of critical issues in the implementation and tests for handling the redirect error that will prevent the feature from working as intended. I've also included some suggestions to improve the design and type safety of the state management and the base strategy class, which will enhance maintainability.
Pulkit0110
force-pushed
the
bidi-reads-retry3
branch
from
d5c430d to
59b006c
Compare
chandra-siri
previously approved these changes
Nov 4, 2025
gcf-owl-bot
Bot
removed
the
owlbot:run
Pulkit0110
force-pushed
the
bidi-reads-retry3
branch
from
59b006c to
667d719
Compare
product-auto-label
Bot
added
size: s
chandra-siri
approved these changes
Nov 5, 2025
Pulkit0110
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added implementation to extract
routing_tokenfrom BidiReadObjectRedirectedError.