{{ message }}
Repository navigation
feat: enable non-blocking mode for generation pipeline - #3772
Merged
gcf-merge-on-green[bot] merged 4 commits intoOct 14, 2026
Merged
Conversation
This PR modifies the core generator to include a new flag that sets a threshold on allowed failed generations before the pipeline treats this invocation as a failure (and a nonzero exit code). This PR further modifies the core generation loop to capture panics and convert them to errors so that we can avoid fatal generations. Finally, this PR adds a new target to the Makefile that leverages this new flag, and switches the nightly discogen job to use this target. We do this rather than modifying the existing "all" target to add new flags as I'm not sure of existing expectations on the target. Related: b/568903157
noahdietz
reviewed
Oct 14, 2026
noahdietz
approved these changes
Oct 14, 2026
shollyman
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the core generator to include a new flag that sets a threshold on allowed failed generations before the pipeline treats this invocation as a failure (and a nonzero exit code).
This PR further modifies the core generation loop to capture panics and convert them to errors so that we can progress in the face of fatal generation attempts. The PR also re-enable(s) some skipped APIs to validate this behavior.
Finally, this PR adds a new target to the Makefile that leverages this new flag, and switches the nightly discogen job to use this target. We do this rather than modifying the existing "all" target to add new flags as I'm not sure of existing consumers/expectations on the target
Related: b/568903157