{{ message }}
Repository navigation
chore: sync actions from gh-aw@v0.85.0 - #207
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
Status reporting has correctness gaps, and credential restoration may leave persisted authentication data behind.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Syncs runtime action scripts with gh-aw@v0.85.0.
Changes:
- Adds safe-output status reporting and label normalization.
- Expands review-thread and threat-result parsing.
- Improves Git authentication, checkout depth handling, and provider endpoints.
File summaries
Review details
Suppressed comments (1)
setup/js/safe_outputs_status.cjs:22
- A deferred item that fails during retry still retains
deferred: true: the explicit-failure path only updatessuccess/error, and the exception path only updateserror. This predicate then excludes that real failure, allowingitems_failedto remain zero andstatusto reportsuccess. Clear the deferred flag in both retry failure paths before computing status.
const itemsFailed = safeResults.filter(isFailedProcessingResult).length;
- Files reviewed: 10/10 changed files
- Comments generated: 3
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| */ | ||
| function computeSafeOutputsStatus(results) { | ||
| const safeResults = Array.isArray(results) ? results : []; | ||
| const itemsSucceeded = safeResults.filter(r => r?.success).length; |
Comment on lines
+1683
to
+1684
| setSafeOutputsStatusOutputs(safeOutputsStatus); | ||
| statusOutputsSet = true; |
Comment on lines
+123
to
+124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of actions from gh-aw at
v0.85.0.