{{ message }}
Add Windows integration tests showing that subst is handled inconsistently#22087
Open
jketema wants to merge 1 commit into
Open
Add Windows integration tests showing that subst is handled inconsistently#22087jketema wants to merge 1 commit into
subst is handled inconsistently#22087jketema wants to merge 1 commit into
Conversation
github-actions
Bot
added
C#
JS
Java
Python
Go
Ruby
Rust
jketema
force-pushed
the
subst
branch
2 times, most recently
from
1c3f36d to
3c83d27
Compare
jketema
changed the title
subst is handled inconsistently
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Windows-only integration tests across multiple language packs to demonstrate inconsistent handling of subst-mapped source roots when extracting files and evaluating whether file paths are treated as relative to the source root.
Changes:
- Introduce new
substintegration-test directories for Rust, Ruby, Python, JavaScript, Go, Java/Kotlin, and C#. - For each test: create a database with
source_rooton asubstdrive, then run a small query and compare.expectedresults to show (in)consistencies. - Add minimal source files per language to drive extraction on Windows.
Show a summary per file
Review details
- Files reviewed: 32/32 changed files
- Comments generated: 1
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows that we do not consistently handle this across the CLI and the various extractors. All tests are: extract a file, check if the extracted file is relative to the source root, where the source root is a
substdrive.