{{ message }}
Closure Compiler wrong assignment order in instantiateReactComponent#8895
Merged
Conversation
Contributor
Author
anmonteiro
changed the title
instantiateReactComponent
Collaborator
|
This looks fine by itself. However, just to set expectations, I’m not quite sure when we’ll cut another patch release, and React 16 will contain a completely rewritten core, so this change won’t affect it. |
Contributor
Author
|
Thanks! I understand. So to avoid encountering similar problems with Fiber, are there instructions to build master locally and take it for a spin? |
Collaborator
|
Yea. You should be able to build from master and then import |
Contributor
Author
|
Great. Will do and report any issues I encounter along the way. |
Contributor
Author
bvaughn
pushed a commit
that referenced
this pull request
Mar 29, 2017
1 task
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #8894