{{ message }}
Repository navigation
feat(glue-alpha): new hasEncryptedData property - #38511
Merged
Merged
Conversation
Glue tables have a storage descriptor, in which certain properties may be configured. One of them is `has_encrypted_data`, that is used by Athena do handle encryption when the data is client-side encrypted (server side encrypted data is encrypted and decrypted transparently). Currently, in `S3Table` and `ExternalTable` this value is hard-coded to `true`. Although there is a way to override this value, it's incidental (by adding a `has_encrypted_data` to the free-form `parameters` property). Add a type safe `hasEncryptedData` property to `TableBaseProps`. This is now the only way to override this value. BREAKING CHANGE: a differing/tokenized `has_encrypted_data` supplied via `parameters` now throws.
Contributor
aws-cdk-automation
previously requested changes
Aug 7, 2026
otaviomacedo
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
August 7, 2026 08:38
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
August 7, 2026 09:40 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 7, 2026 09:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
alvazjor
reviewed
Aug 13, 2026
| throw new ValidationError( | ||
| lit`HasEncryptedDataConflict`, | ||
| `the \`${key}\` table parameter is managed by the \`hasEncryptedData\` property; ` + | ||
| `remove it from \`parameters\` (got ${JSON.stringify(supplied)}, expected ${JSON.stringify(managed)})`, |
Contributor
There was a problem hiding this comment.
Nit: ... remove it from parameters and use the official property instead.... I can see a scenario where someone just reads remove it from the parameters and doesnt add it back in the new prop, and if they had false in the parameters workaround, we will flip their decision
Updated error message to clarify usage of hasEncryptedData property.
otaviomacedo
temporarily deployed
to
automation
August 13, 2026 12:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
automation
August 13, 2026 12:31 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
alvazjor
approved these changes
Aug 13, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 37 minutes 10 seconds in the queue, including 36 minutes 40 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
August 13, 2026 14:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue tables have a storage descriptor, in which certain properties may be configured. One of them is
has_encrypted_data, that is used by Athena do handle encryption when the data is client-side encrypted (server side encrypted data is encrypted and decrypted transparently).Currently, in
S3TableandExternalTablethis value is hard-coded totrue. Although there is a way to override this value, it's incidental (by adding ahas_encrypted_datato the free-formparametersproperty).Add a type safe
hasEncryptedDataproperty toTableBaseProps. This is now the only way to override this value.BREAKING CHANGE: a differing/tokenized
has_encrypted_datasupplied viaparametersnow throws.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license