{{ message }}
Forgerock OAuth provider#13499
Draft
bddvlpr wants to merge 1 commit into
Draft
Conversation
Abstracted the shared OIDC token exchange into a new AbstractOIDCAuth2PRovider base class.
bddvlpr
force-pushed
the
feature_forgerock-oauth
branch
from
6cc6acd to
3284edd
Compare
Member
|
@bddvlpr |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13499 +/- ##
=========================================
Coverage 18.94% 18.94%
- Complexity 18363 18365 +2
=========================================
Files 6192 6194 +2
Lines 556361 556380 +19
Branches 67908 67909 +1
=========================================
+ Hits 105397 105413 +16
- Misses 439393 439394 +1
- Partials 11571 11573 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
DaanHoogland
approved these changes
Jun 26, 2026
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm. I don’t think the current smoke test suite makes sense for this PR. manual testing needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ForgeRock as a supported OAuth2 identity provider. While writing it up I noticed that the new Keycloak provider (committed 4 days ago) would have been a line-for-line copy of this OIDC pipeline. Rather than duplicating it I've abstracted the process into a shared OIDC provider and reduced both the new Keycloak and ForgeRock providers to thin subclasses. \
Perhaps in the future this should be handled as an unbound provider (just a generic OIDC provider, pluggable with any OIDC-compliant server), but for now, this'll do.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Currently only tested against a mock setup, hence why this is a draft. Moved (and merged) the keycloak test into the abstraction layer test.
How did you try to break this feature and the system with this change?