Comparing 10.2.3...10.2.4 · angular/angular · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10.2.3
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 10.2.4
Choose a head ref
  • 4 commits
  • 11 files changed
  • 4 contributors

Commits on Nov 18, 2020

  1. build: update to latest "yargs" package

    The 15.x versions of `yargs` relied upon a version of `y18n` that
    has a SNYK vulnerability.
    This commit updates the overall project, and therefore also the
    `localize` and `compiler-cli` packages to use the latest version
    of `yargs` that does not depend upon the vulnerable `y18n`
    version.
    The AIO project was already on the latest `yargs` version and so
    does not need upgrading.
    
    Fixes #39743
    petebacondarwin committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1806d6e View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. fix(core): fix possible XSS attack in development through SSR. (#40152)

    Escape the content of the strings so that it can be safely inserted into a comment node.
    The issue is that HTML does not specify any way to escape comment end text inside the comment.
    `<!-- The way you close a comment is with "-->". -->`. Above the `"-->"` is meant to be text
    not an end to the comment. This can be created programmatically through DOM APIs.
    
    ```
    div.innerHTML = div.innerHTML
    ```
    One would expect that the above code would be safe to do, but it turns out that because comment
    text is not escaped, the comment may contain text which will prematurely close the comment
    opening up the application for XSS attack. (In SSR we programmatically create comment nodes which
    may contain such text and expect them to be safe.)
    This function escapes the comment text by looking for the closing char sequence `-->` and replace
    it with `-_-_>` where the `_` is a zero width space `\u200B`. The result is that if a comment
    contains `-->` text it will render normally but it will not cause the HTML parser to close the
    comment.
    
    PR Close #40152
    mhevery authored and alxhub committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0b8e3d5 View commit details
    Browse the repository at this point in the history
  2. fix(core): set ngDevMode to false when calling enableProdMode() (…

    …#40160)
    
    The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
    https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.
    
    PR Close #40160
    alan-agius4 authored and alxhub committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    90570c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Configuration menu
    Copy the full SHA
    4a11226 View commit details
    Browse the repository at this point in the history
Loading