{{ message }}
Repository navigation
fix: handle unhandled promise rejections in retry behavior - #757
Merged
Merged
Conversation
Fix crash with "unsettled top-level await" warning when retry behavior causes link checks to fail. Two issues were causing the crash: 1. The top-level `await main()` in cli.ts had no error handling 2. The queue used `.finally()` but no `.catch()` for rejected promises Changes: - Wrap `await main()` in try-catch to handle errors gracefully - Add `.catch()` to queue item execution to prevent unhandled rejections - Add test case to prevent regression 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #754
await main()in try-catch to handle errors gracefully.catch()to queue item execution to prevent unhandled promise rejectionsRoot Cause
Two issues were causing the "unsettled top-level await" crash when retry behavior failed:
cli.ts: The top-level
await main()had no error handling. When errors occurred during retries, they propagated as unhandled rejections.queue.ts: The queue used
.finally()but no.catch(). When queued promises (like retry crawls) rejected, the errors were unhandled.Test plan
should handle all retries failing without crashing (issue #754)that simulates the crash scenario🤖 Generated with Claude Code