{{ message }}
Repository navigation
Limit str to 100 to avoid ReDoS of 0.3s - #89
Merged
Merged
Conversation
Contributor
|
Sweet! Thank you. 😊 |
Author
|
Hey @leo! |
|
Sad that module authors does not care about performance at all. |
Contributor
|
@karenyavine It was just released with version 2.0.0! 🎉 |
|
@leo, thanks for the fix and the release. |
Contributor
|
Because we lowered the limit. So if people have longer strings in place, it will break. |
tkadlec
referenced
this pull request
in dashersw/cote
Jun 5, 2017
Snyk notoriously reports on the ms package used by socket.io, which actually is no vulnerability, and the author rejected snyk's fix. It looks bad on the README, so removing snyk until they fix their attitude.
Closed
This was referenced Sep 20, 2020
This was referenced Oct 5, 2020
This was referenced May 12, 2022
This was referenced Mar 7, 2023
This was referenced Feb 25, 2026
malapeiro
added a commit
to malapeiro/ms
that referenced
this pull request
Sep 24, 2026
The parse() function accepts strings of length 1 to 100, but the error message stated 1 to 99. Aligns the message with the actual validation, matching the intent of PR vercel#89 ("Limit str to 100").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
The fix for CVE-2015-8315 was incomplete. Limiting the input to 10,000 chars reduced the risk significantly but it is still possible to cause a delay of 0.3s. Suggested to limit it to 100 chars as there is no reason for a date to be over that :)
PoC:
Thanks,
Karen Yavine
Security Analyst @ snyk.io