perf: try `pread` like `zarrs`'s use of `File::read_exact_at` by ilan-gold · Pull Request #4039 · zarr-developers/zarr-python · GitHub
Skip to content

perf: try pread like zarrs's use of File::read_exact_at#4039

Draft
ilan-gold wants to merge 3 commits into
mainfrom
ig/pread
Draft

perf: try pread like zarrs's use of File::read_exact_at#4039
ilan-gold wants to merge 3 commits into
mainfrom
ig/pread

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor

After our conversation on Wednesday, I got to thinking more about what zarr-python doesn't do that zarrs, for example, does and this came to mind.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 5, 2026
@ilan-gold ilan-gold added benchmark Code will be benchmarked in a CI job. and removed needs release notes Automatically applied to PRs which haven't added release notes labels Jun 5, 2026
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

@codspeed-hq

codspeed-hq Bot commented Jun 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Code will be benchmarked in a CI job.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant