fix(release): sign Windows installers with SignPath · xhwgithub/orca@4ea550b · GitHub
Skip to content

Commit 4ea550b

Browse files
OrcaWinnwparker
andauthored
fix(release): sign Windows installers with SignPath
Co-authored-by: Neil <neil@stably.ai>
1 parent 1a7c579 commit 4ea550b

3 files changed

Lines changed: 176 additions & 19 deletions

File tree

‎.github/workflows/release-cut.yml‎

Lines changed: 166 additions & 7 deletions

‎config/electron-builder.config.cjs‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,11 @@ module.exports = {
142142
},
143143
win: {
144144
executableName: 'Orca',
145+
// Why: Windows installers are signed after electron-builder packaging by
146+
// SignPath, so the packager cannot infer the updater publisherName.
147+
signtoolOptions: {
148+
publisherName: 'SignPath Foundation'
149+
},
145150
extraResources: [
146151
...commonExtraResources,
147152
winSpeechNativeResource,

‎src/main/updater.ts‎

Lines changed: 5 additions & 12 deletions

0 commit comments

Comments
 (0)