Pinning/Unpinning a Post to a Collection should replicate API's behaviour · Issue #8 · writefreely/writefreely-swift · GitHub
Skip to content

Pinning/Unpinning a Post to a Collection should replicate API's behaviour #8

Open

Description

@AngeloStavrow

Currently, WriteFreelyClient.pinPost(postId: at position: in collectionAlias: completion:) and WriteFreelyClient.unpinPost(postId: from collectionAlias: completion:) take a single post ID String.

That's not in line with how the WriteFreely API works — both /api/collections/{COLLECTION_ALIAS/pin and /api/collections/{COLLECTION_ALIAS/unpin take an array of objects ([{id: String, position: Int}] for the former, [{id: String}] for the latter).

The client should be fixed to handle bulk pinning and unpinning, just like the API. This issue is classified a bug because it diverges from the API's behaviour.

(It may be a good idea to get #7 in place first before working on this.)

Activity

  1. changed the title [-]Pinning/Unpinning a Post to a Collection should take an array of Posts as argument.[/-] [+]Pinning/Unpinning a Post to a Collection should replicate API's behaviour[/+] on Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions