AUTH-7097

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with the documentation assessment depending on PR #1719.

Summary

The runtime moves to v2 flag payloads and evaluates rules in order. The first matching rule can serve either true or false.

• Feature flags now use the first matching rule to choose their value.
• The runtime polls version-2 flag data and keeps complete rule-based snapshots.

Previous thread context:

• stanleyphu disputed the custom-target finding because the API reserves user and organization; Greptile withdrew it. The current code also removes legacy conversion.
• stanleyphu accepted the response-type break as intentional for the major release. The current README describes FlagPollResponse as { version: 2, flags }.
• stanleyphu accepted dropped disabled-target changes as intentional because they never affected evaluation. Greptile withdrew that finding; the current runtime rejects v1 data entirely.

All supplied previous threads were unnumbered, so none require numbered previous-finding entries.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Poll v2 payload] --> B{Payload passes checks?}
  B -->|No| C[Keep last good flags]
  B -->|Yes| D[Replace cached flags]
  D --> E{Flag enabled?}
  E -->|No| F[Serve off_value]
  E -->|Yes| G[Check rules in array order]
  G --> H{A rule matches?}
  H -->|Yes| I[Serve first matching value]
  H -->|No| J[Serve default_value]
  F --> K[Use caller default if value is not boolean]
  I --> K
  J --> K

_{Reviews (5) · Last reviewed commit: "fix(feature-flags): Explain unreadable p..." · Reviewed by Greptile}

How do we plan to roll this out? I imagine now that we have the v2 version of the SDK API shipped, we can just ship this without waiting for the full rollout of targeting rules.

disabled v1 targets get dropped since they don’t affect evaluation. We should call this out in the migration notes.

However, this would break existing targeting, so I'm wondering when the right order to ship this SDK change would be

⚓ Shipyard review suggestion

Suggested team: applied-ai, based on recent contributors to the changed files (@nicknisi).

• Assign @hadihallak · 0 assignments in the last 7 days
• Assign @jacobiajohnson · 0 assignments in the last 7 days
• Assign @meganspaulding · 0 assignments in the last 7 days
• Pick for me · balances recent workload

Links open Shipyard for confirmation. Choosing a reviewer overrides availability; “Pick for me” skips known absences.
Comment /tag <team> for a team or /tag to infer one. Tag the same team again to reroll.

Shipyard Analysis

⏳ Generating analysis...

⚓ Explore the analysis in depth in Shipyard · 🔄 Re-run analysis

⚓ Review requested from @nicknisi for team dx, requested by @stanleyphu.

Shipyard Analysis

⏳ Generating analysis...

⚓ Explore the analysis in depth in Shipyard · 🔄 Re-run analysis

@greptileai review

@greptileai review

@greptileai review

@greptileai review