fix: `gpt-oss` segment budgets by giladgd · Pull Request #489 · withcatai/node-llama-cpp · GitHub
Skip to content

fix: gpt-oss segment budgets - #489

Merged
giladgd merged 12 commits into
masterfrom
gilad/fixGptOssReasoningBudget
Aug 10, 2025
Merged

fix: gpt-oss segment budgets#489
giladgd merged 12 commits into
masterfrom
gilad/fixGptOssReasoningBudget

Conversation

@giladgd

@giladgd giladgd commented Aug 10, 2025

Copy link
Copy Markdown
Member

Description of change

  • feat: comment segment budget
  • feat(Electron template): comment segments
  • feat(Electron template): improve completions speed when using functions
  • feat(Electron template): start with inspect script
  • feat(Electron template): add a link to download gpt-oss
  • fix: using segment budgets with gpt-oss models
  • fix: detect more variations of Harmony chat template
  • fix: use a model message for user prompt completion on unsupported models by default
  • fix(Electron template): don't render <br/> in a thought excerpt
  • docs: using comment segments
  • docs: improve gpt-oss blog post

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd
giladgd requested a review from ido-pluto August 10, 2025 21:32
@giladgd giladgd self-assigned this Aug 10, 2025

@ido-pluto ido-pluto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd
giladgd enabled auto-merge (squash) August 10, 2025 22:05
@giladgd
giladgd merged commit 30eaa23 into master Aug 10, 2025
18 checks passed
@giladgd
giladgd deleted the gilad/fixGptOssReasoningBudget branch August 10, 2025 23:04
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants